Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CALIB_RCT_UPDATER to 0 if disabled #1586

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

davidrohr
Copy link
Collaborator

No description provided.

@davidrohr davidrohr marked this pull request as ready for review April 9, 2024 08:01
Copy link

github-actions bot commented Apr 9, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6-2023-PbPb-apass2

@davidrohr davidrohr merged commit e65a008 into AliceO2Group:master Apr 9, 2024
5 checks passed
@chiarazampolli
Copy link
Collaborator

Hello @davidrohr ,
In async, we now have:

/cvmfs/alice.cern.ch/el9-x86_64/Packages/O2DPG/daily-20240409-0200-1/DATA/common/setenv_calib.sh: line 253: CALIB_RCT_UPDATER: unbound variable

Does this PR fix it? Yesterday I did not see it in my tests, it must have been something that sneaked in after I updated to dev in the morning.
Chiara

@davidrohr
Copy link
Collaborator Author

@chiarazampolli : Yes, it should fix it. A fix for a problem at P2 which was commited yesterday was incomplete.

@chiarazampolli
Copy link
Collaborator

Ok, then I need to wait for a new build for async...
I merged my PR since with my dev (from yesterday morning) all was good. Was this not spotted in any CI?

@shahor02
Copy link
Collaborator

shahor02 commented Apr 9, 2024

What was the problem at P2? Adding RCT_UPDATER passed fullCI.

@davidrohr
Copy link
Collaborator Author

davidrohr commented Apr 9, 2024

SYNCMODE=1 was not set in production.desc, which let to different barrel TF calib datatype spects in calib-workflow.sh and aggregator-workflow.sh.
In some cases, e.g. TPC only, this could lead to one thinking the RCT_UPDATER is present, the other not, and an output proxy was created without an input proxy.
It was not seen in FullCI, since the FullCI actually runs the calib parts, but in the same workflow, and without the proxies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants