TOF: adapt to change in CCDB fetcher

[ercolessi]

Change required after the merge of this PR: AliceO2Group/QualityControl#2261
Following also https://its.cern.ch/jira/browse/QC-1166

Could you confirm if this change enough @ktf @chiarazampolli ?

cc: @noferini @njacazio

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

[noferini]

We probably need to update
MC/config/QC/json/tofdigits.json
as well.
I will run a test as soon as the today tag is available

[ercolessi]

I disabled the call to calibration objects in the jsons since in production we saw this new call produces crashes to be understood.

@noferini @ktf @chiarazampolli

[noferini]

It looks fine. Thanks

[chiarazampolli]

Hello @ercolessi ,
What do you mean that in production it crashes?
Here what I am successfully running locally for async reco:

zampolli@pcalicecz5:~/SOFT/alibuild/ali-o2-dev1/O2DPG$ git diff
diff --git a/DATA/production/qc-async/tof.json b/DATA/production/qc-async/tof.json
index f8a259e1..5ffaf3d3 100644
--- a/DATA/production/qc-async/tof.json
+++ b/DATA/production/qc-async/tof.json
@@ -33,7 +33,7 @@
         "maxNumberCycles": "-1",
         "dataSource": {
           "type": "direct",
-          "query": "tofdigits:TOF/DIGITS/0;readoutwin:TOF/READOUTWINDOW/0;patterns:TOF/PATTERNS;diafreq:TOF/DIAFREQ/0",
+          "query": "tofdigits:TOF/DIGITS/0;readoutwin:TOF/READOUTWINDOW/0;patterns:TOF/PATTERNS;diafreq:TOF/DIAFREQ/0;channelCalib:TOF/CHCALIB/0?lifetime=condition&ccdb-path=TOF/Calib/ChannelCalib;lhcPhase:TOF/LHCP/0?lifetime=condition&ccdb-path=TOF/Calib/LHCphase",
           "query_comment" : "100% sampling"
         },
         "taskParameters": {

[noferini]

Hello @ercolessi , What do you mean that in production it crashes? Here what I am successfully running locally for async reco:

zampolli@pcalicecz5:~/SOFT/alibuild/ali-o2-dev1/O2DPG$ git diff
diff --git a/DATA/production/qc-async/tof.json b/DATA/production/qc-async/tof.json
index f8a259e1..5ffaf3d3 100644
--- a/DATA/production/qc-async/tof.json
+++ b/DATA/production/qc-async/tof.json
@@ -33,7 +33,7 @@
         "maxNumberCycles": "-1",
         "dataSource": {
           "type": "direct",
-          "query": "tofdigits:TOF/DIGITS/0;readoutwin:TOF/READOUTWINDOW/0;patterns:TOF/PATTERNS;diafreq:TOF/DIAFREQ/0",
+          "query": "tofdigits:TOF/DIGITS/0;readoutwin:TOF/READOUTWINDOW/0;patterns:TOF/PATTERNS;diafreq:TOF/DIAFREQ/0;channelCalib:TOF/CHCALIB/0?lifetime=condition&ccdb-path=TOF/Calib/ChannelCalib;lhcPhase:TOF/LHCP/0?lifetime=condition&ccdb-path=TOF/Calib/LHCphase",
           "query_comment" : "100% sampling"
         },
         "taskParameters": {

It crashed at P2 in data acquisition

[chiarazampolli]

Async reco does not crash, I would leave the json for async with the flag "true", if that is correct.
Chiara

[noferini]

Async reco does not crash, I would leave the json for async with the flag "true", if that is correct. Chiara

It is a risk. Up to you

[chiarazampolli]

But what should be the flag? true or false? Isn't it wrong to have the wrong value, just because it works?

[noferini]

But what should be the flag? true or false? Isn't it wrong to have the wrong value, just because it works?

From our point of view they are both valid. We don't strictly need calibrations for QC

[chiarazampolli]

Ok, then let's make everything consistent, even if I think one should investigate why it fails - for me it is not normal. Don't you have a valid entry maybe? A default one for QC, or one from a previous run?

[ktf]

Maybe I missed it, could we have the stacktrace of the crash?

[chiarazampolli]

Hello @noferini , @ercolessi ,
I can merge this, but I think we should understand what is making the online reco fail. What do you think?
Chiara

[noferini]

Hello @noferini , @ercolessi , I can merge this, but I think we should understand what is making the online reco fail. What do you think? Chiara

As discussed also on Monday we are following up this with @ktf

[chiarazampolli]

Hello @ercolessi , @noferini ,
Should I merge?
Chiara

[noferini]

H @chiarazampolli , we can merge it.
Francesco