Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced new environment config variable #1756

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

jackal1-66
Copy link
Collaborator

O2DPG_MC_CFG_ROOT is going to replace O2DPG_ROOT inside the config files. This will make the system more flexible by allowing the user to change this variable on-the-fly, and hence not be limited by the loaded version of O2DPG. At environment loading it will be by default equal to O2DPG_ROOT, as specified in PR 5649

O2DPG_MC_CFG_ROOT is going to replace O2DPG_ROOT inside the config files. This will make the system more flexible by allowing the user to change this variable on-the-fly, and hence not be limited by the loaded version of O2DPG.
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@jackal1-66
Copy link
Collaborator Author

O2DPG_MC_CFG_ROOT changed to O2DPG_MC_CONFIG_ROOT for clarity

@jackal1-66
Copy link
Collaborator Author

jackal1-66 commented Sep 27, 2024

build/O2DPG/sim/o2 will fail until alisw/alidist#5649 is approved. The current PR must be merged only after that one.

@sawenzel
Copy link
Contributor

sawenzel commented Sep 30, 2024

This should fix (or be the foundation for) https://its.cern.ch/jira/browse/O2-5366

@chiarazampolli @alcaliva : I think we could merge it if you are fine with it. (Not that backports after a merge would also need the corresponding commit in alidist/o2dpg alisw/alidist#5649 ... maybe we should backport
this in any case).

update: The CI is failing. We are investigating if this is caused by the present PR... so let's wait a bit before final merge.

@jackal1-66
Copy link
Collaborator Author

Issue seems related to gSystem->ExpandPathName not being able to expand ${O2DPG_MC_CONFIG_ROOT}. It could be that the variable is not set, even though the PR on alidist has been merged, since locally I get the same error message on ROOT when I unset manually the variable.

jackal1-66 added a commit that referenced this pull request Oct 1, 2024
O2DPG_MC_CONFIG_ROOT is not set in the script, so the CI fails. It is set by default equal to O2DPG_ROOT. This PR should fix the issue seen in #1756
sawenzel pushed a commit that referenced this pull request Oct 1, 2024
O2DPG_MC_CONFIG_ROOT is not set in the script, so the CI fails. It is set by default equal to O2DPG_ROOT. This PR should fix the issue seen in #1756
@jackal1-66
Copy link
Collaborator Author

This merged PR #1757 manually sets the new configs variable to O2DPG_ROOT inside the test generators script. This should fix the failing CI

@sawenzel sawenzel merged commit 005df11 into AliceO2Group:master Oct 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants