-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced new environment config variable #1756
Conversation
O2DPG_MC_CFG_ROOT is going to replace O2DPG_ROOT inside the config files. This will make the system more flexible by allowing the user to change this variable on-the-fly, and hence not be limited by the loaded version of O2DPG.
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
O2DPG_MC_CFG_ROOT changed to O2DPG_MC_CONFIG_ROOT for clarity |
build/O2DPG/sim/o2 will fail until alisw/alidist#5649 is approved. The current PR must be merged only after that one. |
This should fix (or be the foundation for) https://its.cern.ch/jira/browse/O2-5366 @chiarazampolli @alcaliva : I think we could merge it if you are fine with it. (Not that backports after a merge would also need the corresponding commit in alidist/o2dpg alisw/alidist#5649 ... maybe we should backport update: The CI is failing. We are investigating if this is caused by the present PR... so let's wait a bit before final merge. |
Issue seems related to gSystem->ExpandPathName not being able to expand ${O2DPG_MC_CONFIG_ROOT}. It could be that the variable is not set, even though the PR on alidist has been merged, since locally I get the same error message on ROOT when I unset manually the variable. |
O2DPG_MC_CONFIG_ROOT is not set in the script, so the CI fails. It is set by default equal to O2DPG_ROOT. This PR should fix the issue seen in #1756
O2DPG_MC_CONFIG_ROOT is not set in the script, so the CI fails. It is set by default equal to O2DPG_ROOT. This PR should fix the issue seen in #1756
This merged PR #1757 manually sets the new configs variable to O2DPG_ROOT inside the test generators script. This should fix the failing CI |
O2DPG_MC_CFG_ROOT is going to replace O2DPG_ROOT inside the config files. This will make the system more flexible by allowing the user to change this variable on-the-fly, and hence not be limited by the loaded version of O2DPG. At environment loading it will be by default equal to O2DPG_ROOT, as specified in PR 5649