Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex #48

Closed
yankana opened this issue Nov 5, 2019 · 3 comments
Closed

Regex #48

yankana opened this issue Nov 5, 2019 · 3 comments

Comments

@yankana
Copy link

yankana commented Nov 5, 2019

Support card and text searches using regular expressions

@AlphaKretin
Copy link
Owner

Sorry for not addressing this earlier, it was during a period I was very busy/distracted. I do intend to improve the search functionality a lot, but I'm still undecided on if and how I want to handle regular expressions. My main worry is that my only user interface is messages on Discord, and being able to parse a user's command such that they can use regex, but don't have to, without confusing users who have no idea what regex is, seems like a slightly daunting task.

@yankana
Copy link
Author

yankana commented Feb 25, 2020

You can make separate commands for it or add a flag for the existing ones. For example .searchregex ...

@kevinlul
Copy link
Collaborator

In new Bastion (DawnbrandBots/bastion-bot#343), the Slash Command replacement for .match and .search will support regular expressions. Lucene query strings support regular expressions, and there is a maximum of 10000 automaton states, guarding against expensive queries, catastrophic backtracking, and other pitfalls of accepting general user regular expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants