Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reaction button performance #54

Closed
4 tasks
AlphaKretin opened this issue Apr 13, 2020 · 1 comment
Closed
4 tasks

Improve reaction button performance #54

AlphaKretin opened this issue Apr 13, 2020 · 1 comment
Labels
bug enhancement major Large, complex changes that will require great investment of time and effort

Comments

@AlphaKretin
Copy link
Owner

Reaction buttons have various issues of varying severity.

  • One issue is that sometimes Bastion will show a "Missing Permissions" error. This seems to be on attempting to remove reactions due to a change of page, while still placing reactions for the old page.

  • In general, it may be beneficial to refactor the system so that if a button should remain on page change, but its purpose changes, we can do that without deleting and readding the button. This will reduce conflicts and waiting time.

  • Bastion does not react to the removal of a reaction, even though to an end-user that's still the same action of clicking the button.

  • Bastion should accept the actual number displayed when calling a result through a command, instead of only modulo 10.

@AlphaKretin AlphaKretin changed the title Improve reaction button performange Improve reaction button performance Apr 13, 2020
@AlphaKretin AlphaKretin added the major Large, complex changes that will require great investment of time and effort label Apr 13, 2020
@kevinlul
Copy link
Collaborator

This is solved by message components (buttons), which will be used in DawnbrandBots/bastion-bot#343

@kevinlul kevinlul closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement major Large, complex changes that will require great investment of time and effort
Projects
None yet
Development

No branches or pull requests

2 participants