Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change applications in platform from being deployed as daemon sets to deployments #142

Open
6 tasks
SandGrainOne opened this issue Feb 7, 2023 · 5 comments
Assignees
Labels
area/infrastructure Issue originates as changes to infrastructure kind/user-story Used for issues that describes functionality for our users. status/blocked Further work depending on the completion of some other task/PoC/issue

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Feb 7, 2023

Description

The purpose of the change is to have autoscaling and improve utilization of the AKS resources.

Additional information

The platform team is working on a base template for platform applications: Altinn/altinn-platform#978

We also hope that this can have a positive effect on the liveness probes and kubernets ability to recyle pods that are unresponsive. There has been cases where Profile has stopped responing on 1 out of 3 requests. We believe it's because one out of three pods across the three nodes in AT was faulty.

Profile appear unresponsive in AT and TT02

I managed to recreate the issue using Postman against AT23. I was getting consistent results where 2 requests worked fine and one request failed. With three nodes there are 3 pods because of daemon sets.

Restarting all instances of the Profile application in the environment had a positive effect. Decided to perform the same restart in all AT environments and in TT02.

Follow up:
Is it the health check that isn't good enough or is there something else going on?

Tasks

  • Make all necessary changes to move Profile over to deployments
  • Ensure labels are set properly for deployments so it can be picked up by KubernetesWrapper
  • Define pod scaling limits
  • Pod disruption settings. "Run at least one pod of every application"
  • Affinity to have the pods for an application spread across nodes

Acceptance Criterias

  • Altinn Profile runs as deployments and not as daemon sets.
@SandGrainOne SandGrainOne added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Feb 7, 2023
@SandGrainOne SandGrainOne changed the title Change applications in platform to be deployed as deamonsets to deployments Change applications in platform from being deployed as deamonsets to deployments Feb 7, 2023
@bengtfredh bengtfredh added area/infrastructure Issue originates as changes to infrastructure and removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Jan 24, 2024
@SandGrainOne SandGrainOne transferred this issue from Altinn/altinn-platform Apr 5, 2024
@SandGrainOne SandGrainOne changed the title Change applications in platform from being deployed as deamonsets to deployments Change applications in platform from being deployed as daemon sets to deployments Jul 9, 2024
@olebhansen
Copy link

@SandGrainOne : is this actually being solved as part of #190 (and thus this issue can be closed as duplicate/"superseeded")?

@olebhansen olebhansen added the status/pending-feedback Awaiting clarification/input from stakeholders etc. label Oct 2, 2024
@SandGrainOne
Copy link
Member Author

@olebhansen yeah, that is the intention.

@olebhansen
Copy link

Closing. Duplicate of #190.

@SandGrainOne SandGrainOne reopened this Oct 7, 2024
@SandGrainOne SandGrainOne self-assigned this Oct 7, 2024
@SandGrainOne
Copy link
Member Author

I reopened this to solve a part of issue #190 . #190 will be postponed slightly in favor of #214.

@SandGrainOne
Copy link
Member Author

It turns out that this type of change also will require a blue-green deployment process. When deploying the changes to kubernetes, it tears down the existing daemon set before starting new pods with the new settings.

This puts a big blocker on this change at least for now. I want us to plan a larger update more of our applications instead of doing a blue green change for every "little" thing.

@SandGrainOne SandGrainOne added status/blocked Further work depending on the completion of some other task/PoC/issue and removed status/pending-feedback Awaiting clarification/input from stakeholders etc. labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infrastructure Issue originates as changes to infrastructure kind/user-story Used for issues that describes functionality for our users. status/blocked Further work depending on the completion of some other task/PoC/issue
Projects
None yet
Development

No branches or pull requests

3 participants