From 384a94d5ef57ebe5311219596650dcbfd96f73dc Mon Sep 17 00:00:00 2001 From: Antoine Toulme Date: Fri, 9 Feb 2024 13:51:35 -0800 Subject: [PATCH] [chore] remove tests checking nil consumer as we're handling nil checks in builder (#31172) See https://github.com/open-telemetry/opentelemetry-collector/pull/9526 for context - we are removing the possibility that the next consumer passed in is nil in the pipelines builders. --- processor/attributesprocessor/factory_test.go | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/processor/attributesprocessor/factory_test.go b/processor/attributesprocessor/factory_test.go index 368d4500aed4..193f2217c02f 100644 --- a/processor/attributesprocessor/factory_test.go +++ b/processor/attributesprocessor/factory_test.go @@ -69,10 +69,6 @@ func TestFactoryCreateTracesProcessor(t *testing.T) { assert.NotNil(t, tp) assert.NoError(t, err) - tp, err = factory.CreateTracesProcessor(context.Background(), processortest.NewNopCreateSettings(), cfg, nil) - assert.Nil(t, tp) - assert.Error(t, err) - oCfg.Actions = []attraction.ActionKeyValue{ {Action: attraction.DELETE}, } @@ -92,10 +88,6 @@ func TestFactory_CreateMetricsProcessor(t *testing.T) { require.NotNil(t, mp) require.NoError(t, err) - mp, err = factory.CreateMetricsProcessor(context.Background(), processortest.NewNopCreateSettings(), cfg, nil) - require.Nil(t, mp) - require.Error(t, err) - cfg.(*Config).Actions = []attraction.ActionKeyValue{ {Key: "fake_key", Action: attraction.UPSERT}, } @@ -132,11 +124,6 @@ func TestFactoryCreateLogsProcessor(t *testing.T) { assert.NotNil(t, tp) assert.NoError(t, err) - tp, err = factory.CreateLogsProcessor( - context.Background(), processortest.NewNopCreateSettings(), cfg, nil) - assert.Nil(t, tp) - assert.Error(t, err) - oCfg.Actions = []attraction.ActionKeyValue{ {Action: attraction.DELETE}, }