Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] E-Mail Login is dependent on capitalization #1740

Open
1 task done
Eikeike opened this issue Jan 25, 2024 · 7 comments · May be fixed by #2118
Open
1 task done

[Bug] E-Mail Login is dependent on capitalization #1740

Eikeike opened this issue Jan 25, 2024 · 7 comments · May be fixed by #2118
Assignees
Labels
bug Something isn't working good first issue Good for newcomers server Pull requests that update server code v4 Issues related to the latest version

Comments

@Eikeike
Copy link

Eikeike commented Jan 25, 2024

Is there an existing issue for this?

  • Yes, I have searched the existing issues and none of them match my problem.

Product Variant

Cloud (http://rxresu.me)

Current Behavior

When you register with your e-mail address and there is a capital letter in the mail address, there will be a server error when you login with the same e-mail with a different capitalization

Expected Behavior

E-Mail login and registration should be completely indepentend from capitalization in the e-mail address.

Steps To Reproduce

  1. Visit rxresu.me
  2. Create an account with a mail that has at least one capital letter
  3. Try logging into that account in the start page again but change the capitalization in the e-mail address

What browsers are you seeing the problem on?

Chrome

What template are you using?

None

Anything else?

No response

@Eikeike Eikeike added bug Something isn't working needs triage Issues that need to be triaged v4 Issues related to the latest version labels Jan 25, 2024
@iprime2
Copy link

iprime2 commented Jan 31, 2024

Hey! @Eikeike While signing up, it stores the email ID as it is provided by the user.
I think we should convert it to lowercase; the same thing happens when we sign up and sign in. Even if there is some capital letter in the email, it still works, even if the email has no capital letter.
One more thing: my email ID is [email protected] and I am signed up with [email protected] I got an email to verify the account.

@gsiddardha
Copy link

See Wiki

Technically all other local-parts are case-sensitive, therefore [email protected] and [email protected] specify different mailboxes; however, many organizations treat uppercase and lowercase letters as equivalent. Indeed, RFC 5321 warns that "a host that expects to receive mail SHOULD avoid defining mailboxes where ... the Local-part is case-sensitive".

While it is a common practice to keep the naming convention case-insensitive, the RFC itself says it is case-sensitive and there are a few mail servers around which allow case-sensitive naming. So, IMHO we should keep this case-sensitive only

@AmruthPillai
Copy link
Owner

Good discussion. As much as the spec of email addresses in general say they are case-sensitive, I'd prefer to enhance user experience. I'll take a peek into this issue, or if anyone's willing to take up this issue, that would be great!

A possible solution would be simply to .toLowerCase() the input provided by the user for username and email, before inserting it into the DB. And also, it would need to be normalised again when checking the credentials (in Local Auth Strategy).

@AmruthPillai AmruthPillai added good first issue Good for newcomers server Pull requests that update server code and removed needs triage Issues that need to be triaged labels Mar 10, 2024
@Rash-Hit
Copy link
Contributor

@AmruthPillai can i work on this ?? i will do those two things , you have mentioned above ??

@sachinninave
Copy link

hello @AmruthPillai , can I go with this issue

@VedantBhawsar
Copy link

hello @AmruthPillai, is this issue still open??
can i trying to solved this issue

@baraich
Copy link

baraich commented Sep 30, 2024

@AmruthPillai I was wondering about the statement you put forward earlier, could you please guide me further taking the quote below as the "beginning" for further conversation. Regards

A possible solution would be simply to .toLowerCase() the input provided by the user for username and email, before inserting it into the DB. And also, it would need to be normalised again when checking the credentials (in Local Auth Strategy).

@kiranraj20 kiranraj20 linked a pull request Dec 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers server Pull requests that update server code v4 Issues related to the latest version
Projects
None yet
8 participants