Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner crashed immediately after start scanning #53

Closed
sagelga opened this issue Nov 11, 2021 · 10 comments
Closed

Scanner crashed immediately after start scanning #53

sagelga opened this issue Nov 11, 2021 · 10 comments

Comments

@sagelga
Copy link
Contributor

sagelga commented Nov 11, 2021

I currently unable to scan with the 0.9 version of the game. No clue on how.

How to reproduce

  • Download a zip file from release
  • Unzip a file
  • Click "Run" when Windows Defender told me not to
  • Click "allow" in user access control
  • Go to the Genshin windows
  • Setup the screen resolution
  • Leave the Genshin windows using Paimon Menu opened
  • Click "Scan Genshin" from the scanner

Information about the PC

  • OS : Windows 10
  • Resolution : 1280 x 720
  • Graphics quality : Low (Default)
  • Native screen resolution : 2K
@ShadowScaleFTL
Copy link

try #40

@sagelga
Copy link
Contributor Author

sagelga commented Nov 12, 2021

Restart the game? Still failed.

@Hypn0tyk
Copy link

Hypn0tyk commented Nov 13, 2021

Have the same issue. Scanner closes the paimon menu, attacks once, then opens it again, then crashes.

UI is not compressed and I have attempted multiple restarts.

@mai-pai
Copy link

mai-pai commented Dec 6, 2021

The application was crashing for me as well on Windows 10. I found that the OCR engine (Tesseract) requires that the Microsoft Visual C++ redistributable be installed on the system. I installed the x86 redistributable and it stopped crashing. The redistributable can be downloaded from Microsoft at the following location: https://docs.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170

@Andrewthe13th
Copy link
Owner

Thanks for the info. I will include that into my readme and maybe project

@sagelga
Copy link
Contributor Author

sagelga commented Dec 6, 2021

@mai-pai Thanks for the reply! Unfortuntately, it still failed.
I have installed Visual Studio 2015, 2017, 2019, and 2022 C++ Redistributable packages and it still crash.
is there's anything that I can help? @Andrewthe13th Maybe some crash log or something like that?

@mai-pai
Copy link

mai-pai commented Dec 6, 2021

@sagelga What you can try since the application doesn't have any logging, is to run the application using dnSpy to capture the error to help determine why it's crashing. That's what I used to determine I was missing the redistributable on my machine.

@sagelga
Copy link
Contributor Author

sagelga commented Dec 7, 2021

@mai-pai Interesting...
I compiled the code via VS in debugger mode and it throw me this.

Failed to find library leptonica.dll
devenv_Q9DInMHbc2

Isn't these dependencies should be listed to be install before using?

@mai-pai
Copy link

mai-pai commented Dec 7, 2021

@sagelga That's should be part of the Tesseract component and should be in the x86 folder under the application folder.

That error is a false positive, I got the same error when the microsoft redistributable wasn't installed. It doesn't mean the dll is missing, it just means it can't load that dll. When you said you installed the redistributable did you install the x64 version or the x86 version? This application is 32bit so it needs the 32bit (x86) redistributable. If you've already installed the redistributable then it's possible "leptonica-1.80.0.dll" is dependent on something else that may not be on your system.

@sagelga
Copy link
Contributor Author

sagelga commented Dec 7, 2021

It worked! I only install x64 and got that error.
Since I have install x84 and redo everything, it worked perfectly! Every single thing!

Dear @Andrewthe13th this is quite crucial that you should tell other people to download the C++ redistributable!
Genshin Impact nor other game all requires this, so you have to manually download it in order for it to work,

Since this issue has been resolved, I will close this issue and might send you a PR for the instruction update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants