Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework check_input() #41

Open
fredjaya opened this issue Jun 25, 2024 · 1 comment
Open

Rework check_input() #41

fredjaya opened this issue Jun 25, 2024 · 1 comment

Comments

@fredjaya
Copy link
Collaborator

fredjaya commented Jun 25, 2024

Related to #27

Usage currently looks like

check_input("pool_size", pool_size)

This is not great as it can be easily misused like

check_input("pool_size", pool_number)

Ideas for improvement:

  • pass only the variable and get the "string" within check_input (lame)
  • remove check_input entirely, and use the underlying check_* functions. This removes the dependency on each needing to assign a string to the correct function (ideal)
@fredjaya
Copy link
Collaborator Author

Adding and using improved functions to/from R/check_input2.R and replace as needed to avoid changing every single usage in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant