Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] get_info in irreversible mode (nodeos_irreversible_mode_if_lr_test) #935

Closed
heifner opened this issue Oct 15, 2024 · 1 comment · Fixed by #944
Closed

[1.1] get_info in irreversible mode (nodeos_irreversible_mode_if_lr_test) #935

heifner opened this issue Oct 15, 2024 · 1 comment · Fixed by #944
Assignees
@linh2931
Labels
bug The product is not working as was intended. 👍 lgtm
Milestone
Spring v1.1.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Oct 15, 2024 •
edited
Loading

Before #920, a node running in irreversible mode would always report the same value for:

"head_block_num":456
"last_irreversible_block_num":456

Now it is possible for a node running in irreversible mode to return different values:

"head_block_num":457
"last_irreversible_block_num":456

See test failure: https://github.com/AntelopeIO/spring/actions/runs/11349047274/job/31565035139

This is possible now because accepted_block is signaled before irreversible_block and a get_info call can come in between those two signals. Before since the get_info ran on the main thread, it could not execute between the two signals.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Oct 15, 2024
@linh2931 linh2931 self-assigned this Oct 16, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Oct 16, 2024
@linh2931
Copy link
Member

linh2931 commented Oct 16, 2024 •
edited
Loading

https://github.com/AntelopeIO/spring/actions/runs/11367787258/job/31622083125?pr=941#step:4:1332

2024-10-16T14:52:15.745123 !!!BUG ON TEST CASE #7 (replayInIrrModeWithRevBlksAndConnectedToProdNode): Head (798) should be equal to lib (797)

@linh2931 linh2931 added bug The product is not working as was intended. and removed triage labels Oct 16, 2024
@linh2931 linh2931 mentioned this issue Oct 16, 2024
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
bug The product is not working as was intended. 👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
Spring v1.1.0-rc1
4 participants
@heifner @jeffwerner00 @linh2931 @enf-ci-bot