Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Make sure nodeos shuts down on controller_emit_signal_exceptions #946

Closed
bhazzard opened this issue Oct 17, 2024 · 0 comments · Fixed by #976
Closed

TEST: Make sure nodeos shuts down on controller_emit_signal_exceptions #946

bhazzard opened this issue Oct 17, 2024 · 0 comments · Fixed by #976
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.1.0-rc1

Comments

@bhazzard
Copy link

Related to: #180

Be consistent in how resource failures cause shutdown:

  • A exception derived from controller_emit_signal_exception should be thrown from the plugin
  • Controller should handle calling app().quit()

Add tests that ensure that all of the exceptions derived from controller_emit_signal_exception result in shutdown
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Oct 17, 2024
@heifner heifner self-assigned this Oct 23, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 23, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 23, 2024
heifner added a commit that referenced this issue Oct 23, 2024
@heifner
GH-946 Add throw_on api endpoint to test_control_plugin
8b4502e
heifner added a commit that referenced this issue Oct 24, 2024
@heifner
GH-946 Add logging and reset after each throw
4dab29e
heifner added a commit that referenced this issue Oct 24, 2024
@heifner
GH-946 Make controller shutdown on controller_emit_signal_exception e…
ca43b63 
…xception
heifner added a commit that referenced this issue Oct 25, 2024
@heifner
GH-946 Reset chain_head if emit throws.
4d876e2
heifner added a commit that referenced this issue Oct 25, 2024
@heifner
GH-946 Let controller_emit_signal_exception escape push_transaction
87dda6b
heifner added a commit that referenced this issue Oct 25, 2024
@heifner
GH-946 Improve logging
b8d256c
heifner added a commit that referenced this issue Oct 25, 2024
@heifner
GH-946 Add new signal throw integration test
fd9b17f
@heifner heifner mentioned this issue Oct 25, 2024
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Oct 25, 2024
heifner added a commit that referenced this issue Oct 25, 2024
@heifner
GH-946 Update comment
cbb33b7
heifner added a commit that referenced this issue Oct 26, 2024
@heifner
GH-946 Move rvalues
4fc3db4
heifner added a commit that referenced this issue Oct 26, 2024
@heifner
GH-946 Fix assert
065cc75
heifner added a commit that referenced this issue Oct 29, 2024
@heifner
Merge pull request #976 from AntelopeIO/GH-946-emit-exception-test
5920982 
Handle exceptions in controller signals
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

Handle exceptions in controller signals AntelopeIO/spring
2 participants
@bhazzard @heifner