Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Undefined" is displayed when the kanji form doesn't exist #7

Open
midse opened this issue Apr 14, 2019 · 5 comments
Open

"Undefined" is displayed when the kanji form doesn't exist #7

midse opened this issue Apr 14, 2019 · 5 comments
Labels
design Issues with UI

Comments

@midse
Copy link

midse commented Apr 14, 2019

Hello!

Thanks for the great work on this app. :)

When the word doesn't have a kanji reading the app displays "Undefined" (for example こそ https://jisho.org/word/%E3%81%93%E3%81%9D). It's a small issue but it would be nice to display the hiragana form only when it occurs!
Undefined

Dimitri

@Anupya
Copy link
Owner

Anupya commented Apr 16, 2019

It might look like a glitch if the kanji doesn't appear for some words. I don't like the 'undefined' either but it is a placeholder until I can think of something better. Let me know if you have any suggestions!

@Anupya Anupya added the design Issues with UI label Apr 16, 2019
@azz
Copy link

azz commented May 27, 2019

If there is hiragana, just show the hiragana again. Otherwise just show the katakana again.

@midse
Copy link
Author

midse commented May 27, 2019

If there is hiragana, just show the hiragana again. Otherwise just show the katakana again.

I agree! It would be really nice. :)

@Anupya
Copy link
Owner

Anupya commented Aug 30, 2019

Some words aren't any different in kanji than in hiragana. How would this way differentiate those words? I think replacing kanji with hiragana/katakana versions would make it more confusing.

"Not all hiraganas can be replaced with kanjis": https://www.quora.com/When-do-you-know-to-use-Katakana-Hiragana-and-Kanji-when-writing-in-Japanese

@midse
Copy link
Author

midse commented Aug 30, 2019

Some words aren't any different in kanji than in hiragana. How would this way differentiate those words? I think replacing kanji with hiragana/katakana versions would make it more confusing.

"Not all hiraganas can be replaced with kanjis": https://www.quora.com/When-do-you-know-to-use-Katakana-Hiragana-and-Kanji-when-writing-in-Japanese

I'm not sure I understand what you're saying.
If we look at the screenshot I posted at the beginning, the word こそ is never written in Kanji and it's only written in Hiragana. (https://jisho.org/word/%E3%81%93%E3%81%9D)
Displaying at the same time both hiragana and katakana for this word is quite confusing.

You should only display the Hiragana (or Katakana if it's relevant) version of the word when there is no Kanji available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues with UI
Projects
None yet
Development

No branches or pull requests

3 participants