From 5dd2a5b766232f913768ce315d838f3bf64e9e40 Mon Sep 17 00:00:00 2001 From: Revati Naik Date: Fri, 14 Feb 2025 15:26:40 -0800 Subject: [PATCH] Fix MACRO naming for repos lock generator --- repos/config/detail/generate_repos_lock.bzl | 4 ++-- repos/config/detail/ros2_config.bzl | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/repos/config/detail/generate_repos_lock.bzl b/repos/config/detail/generate_repos_lock.bzl index 859623b..cb13a30 100644 --- a/repos/config/detail/generate_repos_lock.bzl +++ b/repos/config/detail/generate_repos_lock.bzl @@ -1,8 +1,8 @@ load("@python_deps//:requirements.bzl", "requirement") load("@rules_python//python:defs.bzl", "py_binary") -def generate_repos_lock(*, name, repos_file, setup_file, overlay_files): - """Macro to create a py_binary for generating repos_lock.update""" +def repos_lock_updater(*, name, repos_file, setup_file, overlay_files): + """Executable rule for updating the `setup_file` from a `repos_file` and `overlay_files`.""" py_binary( name = name, diff --git a/repos/config/detail/ros2_config.bzl b/repos/config/detail/ros2_config.bzl index d9669bf..36372e6 100644 --- a/repos/config/detail/ros2_config.bzl +++ b/repos/config/detail/ros2_config.bzl @@ -31,12 +31,12 @@ _archive_attrs = { } BUILD_FILE_CONTENT = """\ -load("@rules_ros//repos/config/detail:generate_repos_lock.bzl", "generate_repos_lock") +load("@rules_ros//repos/config/detail:generate_repos_lock.bzl", "repos_lock_updater") -generate_repos_lock( +repos_lock_updater( name = "repos_lock.update", - repos_file = "ros.repos", # Custom repos file - setup_file = "setup.bzl", # Custom setup file + repos_file = "ros.repos", + setup_file = "setup.bzl", overlay_files = [ {overlays} ],