Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make apicurio-registry work properly with Visual Studio Code #3821

Closed
forsberg opened this issue Oct 16, 2023 · 6 comments · Fixed by #3855
Closed

Make apicurio-registry work properly with Visual Studio Code #3821

forsberg opened this issue Oct 16, 2023 · 6 comments · Fixed by #3855
Labels
priority/low Seeking Contribution Suitable for developers who would like to contribute to the project type/enhancement New feature or request

Comments

@forsberg
Copy link
Contributor

forsberg commented Oct 16, 2023

Feature or Problem Description

Trying to open apicurio-registry in Visual Studio Code, most things work, but the generated code is not found, meaning that code navigation, linting etc suffers badly.

I realize the core developers probably use IntelliJ, but for me, not having to switch editor would help when trying to understand how something works, or when trying to fix a bug.

Proposed Solution

This seems to be a known problem with the vscode-java extension, but there are workarounds. I'm sure that for an experienced java developer, applying fixes from redhat-developer/vscode-java#566 or redhat-developer/vscode-java#177 would be a simple thing. Not so much for me, way too deep into Maven rabbit hole land.

redhat-developer/vscode-java#177 (comment) might indicate that some magic file needs to be added to https://github.com/Apicurio/apicurio-codegen

Additional Context

Please? :)

@forsberg forsberg added the type/enhancement New feature or request label Oct 16, 2023
@apicurio-bot
Copy link

apicurio-bot bot commented Oct 16, 2023

Thank you for reporting an issue!

Pinging @carlesarnal to respond or triage.

@andreaTP
Copy link
Member

Hi @forsberg !

A quick check: apicurio-studio -> you mean Registry right?

Most of us use IntelliJ as a primary IDE for Java projects, that's correct, but some are using Eclipse as well.
I'm personally known to be exceptionally bad with IDEs 😓 and, not having people using/checking constantly the VS Code integration might break from time to time.
I think we would happily merge PRs fixing this aspect, but, it would be on the community to support the maintenance IMHO.

That said, maybe, someone great at IDEs + Java like @fbricon is interested in looking into this.

@andreaTP andreaTP added Seeking Contribution Suitable for developers who would like to contribute to the project priority/low and removed triage/needs-triage labels Oct 18, 2023
@forsberg
Copy link
Contributor Author

Haha, brain overload. Yes, I mean registry :-)

@fbricon
Copy link

fbricon commented Oct 18, 2023

@snjeza PTAL

@forsberg
Copy link
Contributor Author

forsberg commented Oct 19, 2023

I can confirm that #3855 seems to fix the problem. Compliments to the fearless @snjeza who obviously is not afraid of GINORMOUS XML files (like I am).

@andreaTP
Copy link
Member

@fbricon @snjeza I keep facing similar issues with those and other Maven Plugins for generating code, the most recent being with @Javatar81 and this Maven Plugin: https://github.com/fabric8io/kubernetes-client/blob/main/doc/java-generation-from-CRD.md

The workaround of adding the build-helper-maven-plugin always works, but I think it's not the expected behavior as it works ootb in other IDEs (e.g. IntelliJ ).
Is this issue already reported somewhere?
Do you have a ticket I can follow to provide more context and track its resolution?

Thanks a lot in advance! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Seeking Contribution Suitable for developers who would like to contribute to the project type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants