Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bulk edit container from admin container #8449

Open
campmlc opened this issue Jan 15, 2025 · 10 comments
Open

Remove bulk edit container from admin container #8449

campmlc opened this issue Jan 15, 2025 · 10 comments
Assignees
Labels
object tracking Priority-High (Needed for work) High because this is causing a delay in important collection work..

Comments

@campmlc
Copy link

campmlc commented Jan 15, 2025

See #7127
Currently the admin container role is required to use Bulk Edit Container and Create Container Position tools. This request is to change the role required for these tools from Admin Container to Manage Container.
Currently, collection managers are having to provide Admin Container permissions to students as a work around, which is not a good idea.
@mkoo please clarify the wording so we can move this forward. This was discussed and agreed upon at the Genomic Resources committee meeting on 1/10/2025. The change is needed as soon as possible to avoid work stoppage or data loss.

@campmlc campmlc added Priority-High (Needed for work) High because this is causing a delay in important collection work.. object tracking labels Jan 15, 2025
@dustymc
Copy link
Contributor

dustymc commented Jan 16, 2025

Currently the admin container role is required to use Bulk Edit Container

I still do not understand why you think that, please explain.

change the role required for these tools from Admin Container to Manage Container.

Possibly I'm lost, I can kill ArctosDB/dev#146 (and followers) if we need to start that conversation over??

@campmlc
Copy link
Author

campmlc commented Jan 16, 2025

Admin container is the required role for operators to use bulk edit container. I know this for a fact, as does @happiah-madson , because students who have all other required roles cannot access this tool. Only when I finally assign admin container in desperation can they access it.
I do not know how tools get assigned to roles, and clarifying which roles are associated with each tool function was an action item at the meeting blast week.. @mkoo

@campmlc campmlc closed this as completed Jan 16, 2025
@campmlc campmlc reopened this Jan 16, 2025
@campmlc
Copy link
Author

campmlc commented Jan 16, 2025

ArctosDB/dev#146 is a separate but similar issue. We discussed moving create container positions to a new role, for the same reason as above - trusted students need to have access without being given admin container. Bulk edit container could go there as well instead of to manage container. The reason for this issue is that I and others do not have access to comment on Dev issues. We need whatever solution can be implemented most quickly.
Given that there is a dev issue (which I did not know about) for a new role for create container positions? I will amend this request to encompass only bulk edit container.

@campmlc campmlc changed the title Remove bulk edit container and create container position tools from admin container Remove bulk edit container from admin container Jan 16, 2025
@campmlc
Copy link
Author

campmlc commented Jan 16, 2025

@mkoo

@Jegelewicz
Copy link
Member

Jegelewicz commented Jan 16, 2025

According to the tools table, manage_container is what is required for bulk edit container, but it seems as if that is not the lived experience of users, so maybe something is not quite right somewhere.....

I still think the problem is container create position. Maybe if that gets moved to manage_container this will be resolved?

@campmlc
Copy link
Author

campmlc commented Jan 16, 2025

According to the tools table, manage_container is what is required for bulk edit container, but it seems as if that is not the lived experience of users, so maybe something is not quite right somewhere.....

This is definitely the case. It should be in manage container, but is requiring admin container level permissions in actuality. This request is to move the bulk edit container role to manage container where it supposedly already is.

I still think the problem is container create position. Maybe if that gets moved to manage_container this will be resolved?

It is still unclear to me why we need a separate role for this one. Manage container allows for "Create, delete and edit containers. Prerequisite: view_container". I'm not understanding why "create positions" should be more restrictive than "delete containers". To me, this belongs in Manage container.

Perhaps what we need is an "Edit container" role that separates "editing" from "creation and deletion".

@campmlc
Copy link
Author

campmlc commented Jan 16, 2025

To clarify this particular request, for now, and separate it from other issues: Please move "Bulk Edit Container" permissions from where it actually is in admin_container, back to manage_container where the documentation says the it should be.
@dustymc @mkoo

@mkoo
Copy link
Member

mkoo commented Jan 22, 2025

@mkoo mkoo closed this as completed Jan 22, 2025
@campmlc campmlc reopened this Jan 22, 2025
@campmlc
Copy link
Author

campmlc commented Jan 22, 2025

@mkoo the dev issues above do not address the issue posted here. There is a problem with the permissions required to use bulk edit container that needs to be fixed. According to the documentation, bulk edit container permission is granted by manage container. But the actual experience of managers assigning this tool is that we must instead assign admin_container role in order for students to have access to it. There is a disconnect between the documented role and the actual role required to use this tool. We are requesting a separate dev issue from the three referenced above to address this problem.
@happiah-madson

@happiah-madson
Copy link

We have an object tacking meeting in 5 minutes (9 am PST, 12 pm EST) and this will be the one issue we discuss. @mkoo @dustymc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object tracking Priority-High (Needed for work) High because this is causing a delay in important collection work..
Projects
None yet
Development

No branches or pull requests

7 participants