Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reports: finalize database connection isolation #123

Open
dustymc opened this issue Dec 3, 2024 · 16 comments
Open

reports: finalize database connection isolation #123

dustymc opened this issue Dec 3, 2024 · 16 comments

Comments

@dustymc
Copy link
Contributor

dustymc commented Dec 3, 2024

Need Help?

If you require assistance rewriting reports, just ask.

Source

#96

Summary

#96 introduces isolated SQL and detects inappropriate database connections, but does not prevent executing reports with them. The new structure cannot prevent ArctosDB/arctos#8342 until this is completed, but the desire is to be as non-disruptive as possible so a stage two is necessary.

User Interface Changes

The red warning of next release will become a hard stop when this is implemented.

Data Structure Changes

none

@amgunderson
Copy link

I just got my labels working, what does this mean?
Screenshot 2024-12-17 at 10 12 16 AM

@dustymc
Copy link
Contributor Author

dustymc commented Dec 18, 2024

See #96 for background, this filter is necessary to protect the system.

If you're happy with a report, you can just let me know how to find it and I can upgrade. Nothing will change, I'll just check that the SQL isn't doing anything crazy and move it to a protected place.

Anyone is of course welcome to the new role as well, it basically boils down to agreeing to develop in test and not bringing anything to production until it's been tested.

https://handbook.arctosdb.org/documentation/reports.html will continue to develop as we work through this.

@ebraker

This comment was marked as resolved.

@amgunderson

This comment was marked as resolved.

@mkoo
Copy link
Member

mkoo commented Dec 19, 2024

As has been stated in other issues and meetings, a word of reassurance-- there will be no changes to your reports-- we are moving SQL to more secure fields and in this transition you may see red boxes, skulls, green checks, etc as these measures are completed. We dont want your reports to change either! There's no action on your part needed and you can continue to print as needed. But since Dusty is also doing QA/QC on SQL this is a multistep process.

As usual, please file an issue if you want a new report!

@campmlc

This comment was marked as off-topic.

@mkoo

This comment was marked as off-topic.

@dustymc

This comment was marked as resolved.

@dustymc

This comment was marked as resolved.

@dustymc dustymc pinned this issue Jan 1, 2025
@dustymc
Copy link
Contributor Author

dustymc commented Jan 6, 2025

Tech chat with @mkoo - will contact heavy users, check back re: blocking unfiltered execution 20250201.

To get rid of the scary icon in the reporter, just let me know how to find your needed reports in whatever way works best for you.

@acdoll

This comment was marked as resolved.

@dustymc

This comment was marked as resolved.

@acdoll

This comment was marked as resolved.

@Kmullineaux
Copy link

@dustymc Are we able to edit the tags once they've been changed to the new SQL, or should we ensure the tags are finished before requesting help? thanks!

@dustymc
Copy link
Contributor Author

dustymc commented Jan 20, 2025

@Kmullineaux https://arctos.database.museum/Admin/user_roles.cfm#write_report can alter anything but SQL, https://arctos.database.museum/Admin/user_roles.cfm#write_sql can alter SQL. The recommendation will always be to start by gathering the data then working on layout no matter what the current environment look like or who's involved. I'm happy to help with SQL anywhere along the way and can optimize around requested data rather than current usage, just let me know how I can help.

@Kmullineaux
Copy link

@dustymc I've created a new issue for NHSM reports so I'm not filling up this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants