feat: video thumbnail support and translations #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iberflow
changed the title
iberflow
force-pushed
the
feature/video-support
branch
from
583aca2 to
2738d13
Compare
ItsANameToo
changed the title
|
thank you @ignasbernotas , I'll have a look at this PR soon! |
|
hey @ItsANameToo do you need a hand with this? I'm happy to prepare this for a merge, just need a little feedback from you :) |
|
hey @ignasbernotas sorry for the delay, it's been busy and this hasn't been a high enough priority to get to it seems. The PR in itself looks fine, so if you could prepare some testcases to go along with it it's something we're willing to merge. You'll have to run the tests locally as the workflows on the PR require a token that's not available to outside collaborators sadly |
|
Hello, Any chance to get this PR merged to master? Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've added thumbnail support which enables us to use thumbnails for videos. Since temp upload does not use Spatie's media library, therefore does not generate thumbnails, I've replaced the thumb with a "play" icon for video uploads.
Changes are necessary for my application and it also closes #35, #37.
I've not added new test cases, only fixed the current ones. I'll wait for feedback on whether you want this merged, but my use case requires these changes, therefore I'll keep my fork up.
Checklist