refactor argocd context command #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* feat: manifest hydrator Signed-off-by: Michael Crenshaw <[email protected]> * it's monitoring both branches now Signed-off-by: Michael Crenshaw <[email protected]> * push works w/ my personal creds Signed-off-by: Michael Crenshaw <[email protected]> * write metadata, readme, and commands Signed-off-by: Michael Crenshaw <[email protected]> * handle missing branches, missing manifest files, and no-op changes Signed-off-by: Michael Crenshaw <[email protected]> * don't set release name or namespace to values from the app CR Signed-off-by: Michael Crenshaw <[email protected]> * more determinism Signed-off-by: Michael Crenshaw <[email protected]> * handle new branches Signed-off-by: Michael Crenshaw <[email protected]> * show hydration progress Signed-off-by: Michael Crenshaw <[email protected]> * use workqueue Signed-off-by: Michael Crenshaw <[email protected]> * use securejoin, use log contexts, clean up temp dirs Signed-off-by: Michael Crenshaw <[email protected]> * use app auth for github only Signed-off-by: Alexandre Gaudreault <[email protected]> * it works Signed-off-by: Alexandre Gaudreault <[email protected]> * retry failed operations Signed-off-by: Alexandre Gaudreault <[email protected]> * fix Signed-off-by: Alexandre Gaudreault <[email protected]> * codegen Signed-off-by: Alexandre Gaudreault <[email protected]> * it just works Signed-off-by: Alexandre Gaudreault <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…eviewer Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Add test for SecureMkdirAll with existing directory - Verify that SecureMkdirAll correctly handles the case where the directory already exists. - Ensure that the same path is returned when creating an existing directory. Signed-off-by: miiiinju1 <[email protected]> * Add test for SecureMkdirAll with file path - Ensure SecureMkdirAll returns an error when a file path is provided instead of a directory. - Check that the error message indicates a failure to create a directory. Signed-off-by: miiiinju1 <[email protected]> * Add test for SecureMkdirAll with dot-dot path - Test SecureMkdirAll with a path containing to ensure it doesn't traverse outside the root directory. - Verify that the resulting path is as expected and does not use relative paths that escape the root directory. Signed-off-by: miiiinju1 <[email protected]> --------- Signed-off-by: miiiinju1 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…error handling (argoproj#19447) Signed-off-by: Juwon Hwang (Kevin) <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Omer Azmon <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Juwon Hwang (Kevin) <[email protected]> Co-authored-by: thisishwan2 <[email protected]> Co-authored-by: mirageoasis <[email protected]> Co-authored-by: Robin Lieb <[email protected]> Co-authored-by: miiiinju1 <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Omer Azmon <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Juwon Hwang (Kevin) <[email protected]> Co-authored-by: thisishwan2 <[email protected]> Co-authored-by: mirageoasis <[email protected]> Co-authored-by: Robin Lieb <[email protected]> Co-authored-by: miiiinju1 <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> go mod tidy Signed-off-by: Michael Crenshaw <[email protected]> one test file for both implementations Signed-off-by: Michael Crenshaw <[email protected]> simplify Signed-off-by: Michael Crenshaw <[email protected]> fix test for linux Signed-off-by: Michael Crenshaw <[email protected]> fix git client mock Signed-off-by: Michael Crenshaw <[email protected]> fix git client mock Signed-off-by: Michael Crenshaw <[email protected]> address comments Signed-off-by: Michael Crenshaw <[email protected]> unit tests Signed-off-by: Michael Crenshaw <[email protected]> lint Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…9397) * feat(hydrator): handle sourceHydrator fields from webhook Signed-off-by: daengdaengLee <[email protected]> * fix: use GetDrySource instead of GetHydratorDrySource Signed-off-by: daengdaengLee <[email protected]> * test: test if the hydration is properly triggered in the webhook when SourceHydrator is configured Signed-off-by: daengdaengLee <[email protected]> --------- Signed-off-by: daengdaengLee <[email protected]>
…roj#19580) Signed-off-by: nueavv <[email protected]>
D0ri123
reviewed
Oct 1, 2024
Comment on lines
+114
to
+116
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
err가 nil이 아닐 때 처리해주는 util 함수가 주로 사용되고 있는 것 같습니다..!(errors.CheckError(err))
해당 함수 사용을 고려해보는건 어떨까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존의 커맨드도 유지하면서
argocd context list
argocd context use
argocd context delete
3개에 대한 커맨드를 추가했습니다.