Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run notification-catalog, notification-docs #16

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

daengdaengLee
Copy link
Member

issue-19766 브랜치 기준으로 make notification-catalog, make notification-docs 명령어 재실행 결과입니다.
이전 PR에서 누락된 것 같아서 추가합니다.

}]
attachments: "[{\n \"title\": \"{{ .app.metadata.name}}\",\n \"title_link\":\"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}\",\n
\ \"color\": \"#18be52\",\n \"fields\": [\n {\n \"title\": \"Sync Status\",\n
\ \"value\": \"{{.app.status.sync.status}}\",\n \"short\": true\n },\n {\n
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바뀐 코드들 들여쓰기가 안되고 있는 것 같아요..!

@eogns47
Copy link

eogns47 commented Oct 3, 2024

앗 그렇군요..! 확인해보겠습니다! md 파일 들여쓰기는 포맷터가 있나요??

@daengdaengLee
Copy link
Member Author

위 2개 명령어로 자동 생성하는대로 쓰는 것 같아요.
저희 브랜치에서 들여쓰기가 이상한 건 저희가 수정한 templates 폴더 내 파일 내용이 잘못되어서 자동 생성할 때 문제가 생겨서 그런 것 같습니다.
우선 이 PR 은 머지하고 templates 폴더의 파일들 수정 및 자동 생성 다시 한 PR 을 따로 올려서 수정해요~

@daengdaengLee daengdaengLee merged commit edf266f into issue-19766 Oct 3, 2024
3 checks passed
@daengdaengLee daengdaengLee deleted the issue-19766-khl branch October 3, 2024 22:17
@eogns47
Copy link

eogns47 commented Oct 4, 2024

@daengdaengLee 넵 확인했습니다!

daengdaengLee added a commit that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants