Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move parser code to separate package #15

Open
Gskartwii opened this issue Apr 3, 2019 · 0 comments
Open

Refactor: Move parser code to separate package #15

Gskartwii opened this issue Apr 3, 2019 · 0 comments
Labels
enhancement parser The parser code, located in the peer submodule

Comments

@Gskartwii
Copy link
Collaborator

Packet*Layer code should be moved to a separate package, parser.
Likewise, CommunicationContext and schema-related code should also go in the same package, as parser highly depends on it.
Additionally, DefaultPacketReader/Writer also need to be moved to the same package. In the end, this means that default datamodel handlers should be implemented in peer, but alternatively they could still remain in the DefaultPacketReader.

Ultimately, this should make the parser completely independent of the peer.

@Gskartwii Gskartwii added enhancement parser The parser code, located in the peer submodule labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement parser The parser code, located in the peer submodule
Projects
None yet
Development

No branches or pull requests

1 participant