Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove send method #20

Closed
AryaanSheth opened this issue Sep 6, 2024 · 0 comments · Fixed by #22
Closed

Remove send method #20

AryaanSheth opened this issue Sep 6, 2024 · 0 comments · Fixed by #22
Assignees
@AryaanSheth
Labels
enhancement New feature or request

Comments

@AryaanSheth
Copy link
Owner

Since the library is switched to create the request and leaving the send logic to the consumer the send() method will be removed. It will be replaced with a build method that returns the json.object that needs to be sent and the consumer can determine how they want to do that.
@AryaanSheth AryaanSheth added the enhancement New feature or request label Sep 6, 2024
@AryaanSheth AryaanSheth self-assigned this Sep 6, 2024
@AryaanSheth AryaanSheth linked a pull request Sep 6, 2024 that will close this issue
Added build method #22
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AryaanSheth AryaanSheth

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added build method AryaanSheth/gloq
1 participant
@AryaanSheth