Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorException when saving post with no tags #61

Open
pavsid opened this issue Nov 16, 2017 · 4 comments
Open

ErrorException when saving post with no tags #61

pavsid opened this issue Nov 16, 2017 · 4 comments

Comments

@pavsid
Copy link

pavsid commented Nov 16, 2017

Creating a new post without any tags throws the following error:-

production.ERROR: ErrorException: array_diff(): Argument #1 is not an array in /home/asgardcms/public_html/Modules/Tag/Traits/TaggableTrait.php:104

@pavsid
Copy link
Author

pavsid commented Nov 16, 2017

This is the fix..

EloquentPostRepository.php:47

$post->setTags(array_get($data, 'tags', []));

@nWidart
Copy link
Member

nWidart commented Nov 16, 2017

Thanks, you can send a PR with this if you want.

@pavsid pavsid changed the title ErrorException when saving creating new page with no tags ErrorException when saving new page with no tags Nov 16, 2017
@pavsid pavsid changed the title ErrorException when saving new page with no tags ErrorException when saving post with no tags Nov 16, 2017
@pavsid
Copy link
Author

pavsid commented Nov 16, 2017

@nWidart I'd like to start contributing, and am following the steps listed here , but am stuck at Run ./travis.sh - never used travis before, and have never sent a PR before, can you give me some pointers please?!

@pavsid
Copy link
Author

pavsid commented Nov 16, 2017

No need for my PR anyway - looks like this issue was addressed in branch 2.0 so just needs merging into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants