Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on Binaryen proposal #91

Open
ericvergnaud opened this issue Jan 9, 2024 · 2 comments
Open

Comment on Binaryen proposal #91

ericvergnaud opened this issue Jan 9, 2024 · 2 comments

Comments

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Jan 9, 2024

Hi there,

to avoid observed gaps between the TypeScript in this repo and the underlying JavaScript in Binaryen repo, I have submitted a PR that moves the TypeScript source to the Binaryen repo and generates the JavaScript from it, thus ensuring a single source of truth.

The PR is here WebAssembly/binaryen#6192. (If approved, that PR would be followed by a corresponding PR in this repo, adjusting for the change of source of truth for TypeScript)

It would be great if you could comment on that PR rapidly such that the Binaryen team can reach a decision on whether or not to accept the PR.

@dcodeIO
Copy link
Member

dcodeIO commented Jan 14, 2024

I do like the idea of replacing the JS plus separate typings with TS plus generated typings. I'd probably go even further and also generate the API docs from tsc's type info and respective comments while on it. Or even further, and generate all of it while also guaranteeing that the C++, C and JS APIs are in sync.

@ericvergnaud
Copy link
Contributor Author

Following a counter PR WebAssembly/binaryen#6224, I've opened a discussion here: WebAssembly/binaryen#6225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants