-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2139 RIQ FCa : ADI algorithm with RAVC or CVC coronagraph #278
Comments
RIX:
RIX answers
Yes, we are working on a Python (median subtraction) ADI code (based on VIP_HCI) to process simulated METIS APP data that will help us with implementing the corresponding APP pipeline recipe in C.
In the original ADI definition by Marois (2006) they did a further annular optimization to improve noise (I was being overcomplete in mentioning this in the DRLD). In the medsub routine of VIP_HCI (https://vip.readthedocs.io/en/latest/vip_hci.psfsub.html#module-vip_hci.psfsub.medsub) this is the difference between the default mode='fullfr' and mode='annular'. Only the simple fullframe median will be implemented for METIS.
In this context I mean median-combined however it would be easy to provide this as a setting [default median / mean]. I didn't consider any potential gain here. (perhaps in some digitization noise regime?)
The METIS ADI pipeline is mostly there for quicklook reduction at the telescope and to provide the datacubes and metadata needed for HCI experts to use their own optimized code. (imagine awesome futuristic routines from the year 2029 and beyond here). The METIS ADI code should be straightforward to implement and easy to maintain so functionality should be kept to minimum and more specialized approaches are left to the users. We follow the default definition of VIP_HCI (https://vip.readthedocs.io/en/latest/vip_hci.metrics.html#module-vip_hci.metrics.contrcurve). If necessary we can discuss which specific noise estimation method to implement for contrast curve / detection / snr maps with the HCI lead Olivier Absil during PIP FDR. An optional FFT-based high pass filtering (as suggested) might be useful to improve detections and easy to implement.
Agreed, I need to change this to median. Action Item 2237
Clarification: this is about the "optimal" algorithm to determine the contrast and SNRs. We will baseline Mawet et al 2014 following VIP_HCI. |
Todo list: Simulations + processing + writeup
Text corrections in Section 6
|
In the process of making APP prototype code and fixing HEEPS + ScopeSim. |
HEEPS+Scopesim with APP and APP prototype code works. Need to add in 2D maps and put it on github. Also add writeup to DRLD. |
See MET-2237, MET-2139
The text was updated successfully, but these errors were encountered: