Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming v2 refactoring #2

Open
AtjonTV opened this issue Feb 12, 2024 · 0 comments
Open

Upcoming v2 refactoring #2

AtjonTV opened this issue Feb 12, 2024 · 0 comments

Comments

@AtjonTV
Copy link
Owner

AtjonTV commented Feb 12, 2024

I am currently working on Hisho v1.2, in which I added the "explain" commands for commands and builds.

While adding support for explain, I stumbled across a huge deficit in Rust: There is no argument overloading.
So it is not possible to have two functions with the same name, but different argument types or counts.
A function hello(String) and a hello(String, bool) can not co-exist. Same with a hello(String) and hello(i32).

Because of this limitation I had to rename many of the modified functions to include their arity (count of arguments).

So now there are many functions marked as deprecated, that call to functions that have their arity in their name, and it is all a big mess.

With v2, I want to fix this mess. In v2 I will both, remove all the functions marked as deprecated in v1.2, BUT I will also rename all the other functions to remove the arity.

This issue is basically just a public announcement that Hisho v2 will come soon and that it will NOT be API compatible in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant