Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Makefile to avoid recursive make #131

Closed
wants to merge 6 commits into from
Closed

Updated Makefile to avoid recursive make #131

wants to merge 6 commits into from

Conversation

nedbrek
Copy link
Contributor

@nedbrek nedbrek commented Feb 14, 2023

Automatically generate dependencies

@artyomtrityak
Copy link
Member

Builds are failing ^

artyomtrityak
artyomtrityak requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@artyomtrityak artyomtrityak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing

@nedbrek
Copy link
Contributor Author

nedbrek commented Mar 25, 2023

Sorry, I didn't see this failed. Easy fix.

@valdisz valdisz requested a review from artyomtrityak October 6, 2023 16:56
@valdisz valdisz changed the base branch from neworigins to neworigins-v6 October 10, 2023 06:17
@valdisz
Copy link
Contributor

valdisz commented Oct 10, 2023

@nedbrek @jt-traub there were some good changes, but was not merged and now we have conflicts :(
can you help with this?

@jt-traub
Copy link
Contributor

jt-traub commented Oct 10, 2023 •
edited
Loading

@nedbrek @jt-traub there were some good changes, but was not merged and now we have conflicts :( can you help with this?

I can.. but i am not convinced it's necessarily beneficial (or detrimental).. I have seen arguments both for and against recursive make and have never been persuaded that either way is fundamentally better.

Also there are changes in there that are not related to recursive make, which could relatively easily be pulled out into a separate PR which I personally think is better to split the separation of concerns.

@jt-traub
Copy link
Contributor

jt-traub commented May 5, 2024

I have take the bits to automate counting of cities, and the small fix to display practice and added them to a branch of collected PR fixes which I will merge once all tests pass, etc. Closing this PR since I am going to ignore the makefile changes for now.

@jt-traub jt-traub closed this May 5, 2024
@jt-traub jt-traub mentioned this pull request May 5, 2024
Merged
@jt-traub
Copy link
Contributor

jt-traub commented May 5, 2024

Changes, except for the makefile reorg are in PR #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valdisz valdisz valdisz approved these changes

@artyomtrityak artyomtrityak Awaiting requested review from artyomtrityak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nedbrek @artyomtrityak @valdisz @jt-traub @atrytiak