Another set of old PR cleanups. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jt-traub
commented
May 6, 2024
jt-traub
commented
- Non-damaging special effects cleanup
- Non-damaging special effects were reporting 'doing 1 damage' in descriptions which was wrong. This fixes it. See PR effect spells should not have damage #129
- Updated snapshots to reflect the change.
- Consumption and study cost message
- This merges the work done in PR Show unit consumption in events #121 to display costs for studying and all cases where items or money is borrowed for maintenance.
- Found and fixed a bug where allies covering maintenance would end up paying 2x rather than the expected cost.
- Found and fixed all places where 'maintenance' was spelled as 'maintainence'
- Updated all snapshots to reflect these changes.
* Non-damaging special effects were reporting 'doing 1 damage' in descriptions which was wrong. This fixes it. See PR #129. * Updated snapshots to reflect the change.
* This merges the work done in PR #121 to display costs for studying and all cases where items or money is borrowed for maintenance. * Found and fixed a bug where allies covering maintenance would end up paying 2x rather than the expected cost. * Found and fixed all places where 'maintenance' was spelled as 'maintainence' * Updated all snapshots to reflect these changes.
This was referenced May 6, 2024
valdisz
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.