Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User assertions: Allow multiple flags to be resolved on the same record without having to refresh the page #621

Open
peggynewman opened this issue Sep 25, 2024 · 5 comments

Comments

@peggynewman
Copy link

peggynewman commented Sep 25, 2024

A small issue, but an irritating one nonetheless. If a single record currently has two or more flags on it, resolving one ‘locks’ the other flag; it becomes impossible to resolve the second flag without having to refresh the page. This is an unnecessary waste of time.

cc @tmesaglio for testing

@adam-collins
Copy link
Contributor

Please add the steps to reproduce this in the test environment.

I do not know if it is concern, but biocache-service has always distilled multiple user assertions to a single "current status", for both searching and downloads.

@tmesaglio
Copy link

Here's a short video I recorded. This is a super minor issue, but still irritating

video1442024999.mp4

@adam-collins
Copy link
Contributor

The video above shows the process to replicate the issue on an occurrence page.

  1. Create 2 user assertions, with different reason codes.
  2. Click "Verify annotation" on the 2nd user assertion.
  3. Save this verified with the type "Corrected.. ".
  4. Click "Verify annotation" on the 1st user assertion.
  5. An incorrect popup appears. I have seen both the "Confirmation" dialog with the successful message and also the "Confirmation" dialog prefilled with the previously entered information for the 2nd user assertion.

I suspect the issue is that the "Confirmation" dialog is not being correctly reset when re-opened, and as such may still show the successful message and this disables the ability to enter information for the new verification entry.

@adam-collins adam-collins transferred this issue from AtlasOfLivingAustralia/biocache-service Sep 26, 2024
@nielsklazenga
Copy link

As the annotation service is a different service, resolving two annotations without a page update in between is like two people editing the same page at the same time. I reckon blocking a page from being edited when it is being edited by another user is correct behaviour.

@adam-collins
Copy link
Contributor

Record locking is not required as user annotations are unique to userId + recordId + reasonCode. Verification codes are made to this composite unique key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants