Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove demo server entry from favorite server list #834

Closed
TrickyLeifa opened this issue Jul 30, 2022 · 4 comments · Fixed by #888
Closed

Remove demo server entry from favorite server list #834

TrickyLeifa opened this issue Jul 30, 2022 · 4 comments · Fixed by #888
Labels
enhancement Request for functionality not present ui Issues related to the user interface (non-viewport related)

Comments

@TrickyLeifa
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The demo server is in a dumb location; it shouldn't be in the favorite server listing. This also comes as a double problem: simply clicking on the demo server entry will open up the demo server widget! Why??

Describe the solution you'd like
It should be a different button altogether that you have to press in other to activate the demo server mode.

Describe alternatives you've considered
None.

Additional context
This would also get rid of needless complexity associated with code of the server listing.

@TrickyLeifa TrickyLeifa added enhancement Request for functionality not present ui Issues related to the user interface (non-viewport related) labels Jul 30, 2022
@stonedDiscord
Copy link
Member

i think the favorites is a good place for it

@oldmud0
Copy link
Member

oldmud0 commented Jul 31, 2022

option 1: split server list into 3 tabs
image

option 2: change settings button into icon and add demo playback button alongside it
image

did I mention modernizing the darn lobby screen so it doesn't look like it's from 2005? oh yeah that too

@Salanto
Copy link
Contributor

Salanto commented Jul 31, 2022

The split would likely make the most sense as option 2 breaks established behaviour on how to "enter" a server, even if demos are not real servers.

@TrickyLeifa
Copy link
Contributor Author

TrickyLeifa commented Jul 31, 2022

But what's wrong with 2 different kind of textures and one untextured button anyway?

It adds to the flavor.

It's consistent with the codebase.

@Salanto Salanto added this to the 2.11 Full Release milestone Jan 6, 2023
@Salanto Salanto mentioned this issue Jan 29, 2023
@Salanto Salanto linked a pull request Feb 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for functionality not present ui Issues related to the user interface (non-viewport related)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants