Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move showname tickbox into settings menu, remove the old checkbox #853

Open
Crystalwarrior opened this issue Aug 7, 2022 · 1 comment
Open
Labels
ui Issues related to the user interface (non-viewport related)

Comments

@Crystalwarrior
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Clicking on the shownames checkbox currently causes a lock-up (#68) and the worst part is it's far too easy to do so accidentally, especially on themes with the checkbox close to stuff like input box, "pre", etc.

Describe the solution you'd like
Move the "Shownames" checkbox into the Settings menu, call it "Display Shownames", and only make changes to the IC log after the "Save" button is pressed, meaning you only get 1 lock-up at a specific point.

Describe alternatives you've considered
Keeping both and relying on theme makers doesn't solve the issue of the checkbox being mostly useless during normal gameplay and rarely used for anything, it being a source of lag doesn't help

@Crystalwarrior Crystalwarrior modified the milestone: 2.10 Full Release Aug 7, 2022
@oldmud0
Copy link
Member

oldmud0 commented Aug 19, 2022

yeah
but i don't want this for 2.10 because it will jack themes up at the last minute. some of them rely on the presence of the button to establish a sense of symmetry

@Salanto Salanto added this to the 2.11 Full Release milestone Jan 16, 2023
@in1tiate in1tiate added the ui Issues related to the user interface (non-viewport related) label Nov 5, 2023
@Salanto Salanto removed this from the 2.11 Full Release milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues related to the user interface (non-viewport related)
Projects
None yet
Development

No branches or pull requests

4 participants