Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers with large character rosters have some characters not appear on the first page. #854

Closed
ghost opened this issue Aug 10, 2022 · 3 comments · Fixed by #888
Closed

Comments

@ghost
Copy link

ghost commented Aug 10, 2022

Upon connecting to a server that has a massive character roster, some of the characters on the roster doesn't appear on the first page. This is fixed by moving to the next page of characters, then returning back to the first page.

Evidence:
Upon connecting to server:
image
After refreshing via going to next page then back to first page:
image

To reproduce:

  1. Open up the release candidate version of AO 2.10 and connect to a server with a large roster. (Case Cafe, Mountain of Spirits, and Killing Fever Online as good examples for servers with large rosters)

Expected behavior
Behavior should be what was described on first paragraph if steps are done correctly.

OS: Windows 11
Version : 2.10 RC 1

@oldmud0
Copy link
Member

oldmud0 commented Aug 11, 2022

Does it always only show the first 90?

@ghost
Copy link
Author

ghost commented Aug 11, 2022

Does it always only show the first 90?

Yes, whenever you connect to a server with a large roster, it will always show the first 90 upon being connect. This problem usually goes away when "refreshing" the first page via going to the next page of characters and going back to the first page.

@Salanto
Copy link
Contributor

Salanto commented Aug 13, 2022

Yeah, you can reproduce it very easily on CaseCafe.

Salanto added a commit that referenced this issue Feb 11, 2023
This entire system needs a rework, but this will do for now.

Also slightly improves performance by not making it load the character list 4 times, only 2 now :^)
closes #854
@Salanto Salanto linked a pull request Feb 12, 2023 that will close this issue
@Salanto Salanto mentioned this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants