Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save last audio volume instead of setting a default in settings #892

Closed
Salanto opened this issue Feb 15, 2023 · 2 comments · Fixed by #888
Closed

Save last audio volume instead of setting a default in settings #892

Salanto opened this issue Feb 15, 2023 · 2 comments · Fixed by #888
Labels
engine/assets Issues related to INI parsing, path resolution, and asset loading engine/audio Issues related to music and sound effect playback enhancement Request for functionality not present

Comments

@Salanto
Copy link
Contributor

Salanto commented Feb 15, 2023

Right now AO2's volume in the settings is the clients default volume when joining a server. While running changes are made in the mixer.

This creates several issues:

  • Many users are unaware that the audio settings in the menu/config are the default join volumes and wonder why their audio volumes from mixer don't carry over to the enxt time they open the client.
  • It works different than WebAO, which saves your last audio settings and restores them when reopening it
  • It is extremely counter-intuitive to be able to change a setting which does nothing until you rejoin a server.

A solution would be to remove the default audio volume behaviour and just save the last set volume from mixer/settings, allowing both to change volume and restore them from settings for a consistent experience.

@stonedDiscord
Copy link
Member

web parity issue :omegalol:

@Salanto
Copy link
Contributor Author

Salanto commented Feb 15, 2023

:omgparityissue: 😱 😱

@in1tiate in1tiate added enhancement Request for functionality not present engine/assets Issues related to INI parsing, path resolution, and asset loading engine/audio Issues related to music and sound effect playback labels Feb 15, 2023
@Salanto Salanto linked a pull request May 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/assets Issues related to INI parsing, path resolution, and asset loading engine/audio Issues related to music and sound effect playback enhancement Request for functionality not present
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants