Life Could Be A Dream: Adds Vaurca Attendant as a Warrior subspecies #19529
Conversation
ghost
requested review from
|
!wip |
BotBOREALIS
added
the
WIP
ghost
changed the title
|
Current implementation is too snowflake and I have no desire to put it more in line with current subspecies code with any possibility of being told later that it isn't wanted. Anyone else is free to pick it back up. |
ghost
closed this
|
|
ghost
reopened this
ghost
changed the title
|
Project updated. New sprites can be seen here: |
|
I worked with Gabby, suggesting the changes to the sprite and the base stats. Needless to say, this is lore approved. |
|
!review |
BotBOREALIS
added
Review Required
and removed
WIP
Description updated with clothing from all angles! |
| @@ -279,7 +279,7 @@ | |||
| /datum/unarmed_attack/bite/warrior | |||
| attack_name = "warrior bite" | |||
| attack_verb = list("mauled", "lacerated") | |||
| damage = 10 | |||
| damage = 15 | |||
There was a problem hiding this comment.
That's a pretty big buff. Why?
There was a problem hiding this comment.
was requested by @desvenlafaxine. im not intent on sticking with it if not required to but he is free to explain his side first
There was a problem hiding this comment.
IMO it should at least be split into another PR? It's a pretty major balance change.
There was a problem hiding this comment.
This can be dismissed if unwanted. The idea is just that the bite has been heavily nerfed and I wanted the basic Warriors to have a reason to use it.
There was a problem hiding this comment.
Make it a separate PR
NonQueueingMatt
added
the
Changes Required
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DreamySkrell
removed
the
Changes Required
|
removing [changes required] as the warrior bite change was removed from this PR |
|
From a code Perspective that PR is good enough, but I am going to add MD to it to see if we want it |
Arrow768
added
the
⛔ Maintainer Discussion
Arrow768
removed
the
⛔ Maintainer Discussion
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Arrow768
added
the
Changes Required
|
Need to update the PR so the UTs run without issue. |
Basically, Attendants are now a subspecies of Warriors instead of a subspecies of Workers, meaning they carry most of the traits over from Warriors aside from the ones that have been modified by me. They also have a unique appearance that should still work with Vaurca clothing, instead of needing adjustments a la Bulwark. Hopefully, an acceptable alternative to the Attendant subspecies that was previously offered in #17550.
@desvenlafaxine