Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hegemony waypoint #19618

Merged
merged 32 commits into from
Jul 17, 2024
Merged

Conversation

hazelrat
Copy link
Contributor

@hazelrat hazelrat commented Jul 10, 2024

This introduces the Hegemony Waypoint, a hegemony variant of the sensor relay intended to replace the sensor relay in Uueoa-Esa.

TODO:

  • Fix the overmap object spawning twice for some reason
  • Get sensors working
  • Introduce grime and more details to map
  • Exclude sensor relay from Uueoa-Esa
  • Add unique sprite
  • Introduced mapmanip elements so there can be randomised and potentially dangerous stuff in the offsite (maybe)

Featuring randomised rooms!

image

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Jul 10, 2024
@hazelrat
Copy link
Contributor Author

!wip

@BotBOREALIS BotBOREALIS added the WIP The PR is a work in progress and should not be reviewed yet. label Jul 10, 2024
@hazelrat hazelrat changed the title Hegemonic waypoint Hegemony waypoint Jul 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@hazelrat hazelrat requested a review from alsoandanswer as a code owner July 13, 2024 09:43
@hazelrat
Copy link
Contributor Author

!review

@BotBOREALIS BotBOREALIS added Review Required and removed WIP The PR is a work in progress and should not be reviewed yet. labels Jul 15, 2024
@DreamySkrell
Copy link
Contributor

image

for better organization, all sensor relays should be in the same folder: maps\away\away_site\sensor_relay

the current generic relay should be in a folder like maps\away\away_site\sensor_relay\generic or \solarian_prewar or something

and the hegemony waypoint relay should be like maps\away\away_site\sensor_relay\hegemony_waypoint

@@ -10,7 +10,7 @@
sectors = ALL_POSSIBLE_SECTORS
id = "sensor_relay"
template_flags = TEMPLATE_FLAG_SPAWN_GUARANTEED
sectors_blacklist = list(SECTOR_LEMURIAN_SEA) //because finding a sensor relay in hell would be weird
sectors_blacklist = list(SECTOR_LEMURIAN_SEA, SECTOR_UUEOAESA) //because finding a sensor relay in hell would be weird + there is a specific relay variant in uueoa-esa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
make it like this to be more readable

Comment on lines 26 to 33
"waypoint_dock_n",
"waypoint_dock_e",
"waypoint_dock_w",
"waypoint_dock_s",
"waypoint_n_space",
"waypoint_e_space",
"waypoint_w_space",
"waypoint_s_space"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these should be renamed to hegemony_waypoint_ ....

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@hazelrat
Copy link
Contributor Author

as above

All changes implemented.

@DreamySkrell
Copy link
Contributor

image
image
need to change tags on the landmark defs too

@hazelrat
Copy link
Contributor Author

image image need to change tags on the landmark defs too

Done!

@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Jul 17, 2024
Merged via the queue into Aurorastation:master with commit 55a1afd Jul 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants