Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Internal Computing Device access. #19622

Closed
wants to merge 9 commits into from

Conversation

Magisterium2022
Copy link
Contributor

Added AI Internal Computing Device access to a number of programs, such as the Command and Control program, which it was previously unable to interface with.

Signed-off-by: Magisterium2022 <[email protected]>
Signed-off-by: Magisterium2022 <[email protected]>
Signed-off-by: Magisterium2022 <[email protected]>
Signed-off-by: Magisterium2022 <[email protected]>
Signed-off-by: Magisterium2022 <[email protected]>
Signed-off-by: Magisterium2022 <[email protected]>
Signed-off-by: Magisterium2022 <[email protected]>
@Magisterium2022
Copy link
Contributor Author

!review

@FluffyGhoster
Copy link
Contributor

MD because I don't think the AI should have access to any of those programs, besides maybe the docking and teleporter one

@FluffyGhoster FluffyGhoster added the ⛔ Maintainer Discussion The PR will be discussed by the maintainers. label Jul 16, 2024
Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine however

Copy link
Contributor

@NonQueueingMatt NonQueueingMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues we have with this PR:

  1. The account database probably can't even be used by the AI due to it needing an ID card inserted.
  2. Same goes for the ID card changing program - how is that one supposed to work?

@NonQueueingMatt NonQueueingMatt added the Changes Required The PR requires changes before it can be approved and/or merged. label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge Changes Required The PR requires changes before it can be approved and/or merged. ⛔ Maintainer Discussion The PR will be discussed by the maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants