BAPI - mapmanip submap perf improv + mapmanip script #19634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eamySkrell/Aurora.3 into 2024-06-22--bapi-submaps-noop
DreamySkrell
requested review from
Arrow768,
Alberyk and
NonQueueingMatt
as code owners
github-actions
bot
added
🗺️ Mapping - Away Ship/Away Site
github-actions
bot
removed
the
🗺️ Mapping - Away Ship/Away Site
|
!build_bapi |
|
!review |
NonQueueingMatt
approved these changes
Jul 17, 2024
FluffyGhoster
approved these changes
Jul 22, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
perf improv in the form of changing the map container from hashmap to a flat grid
hashmap was only bad for big maps with lots of submaps - did not affect horizon with its one small submap
the script: