Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Reports #32

Open
visch opened this issue Mar 22, 2022 · 0 comments
Open

Custom Reports #32

visch opened this issue Mar 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@visch
Copy link
Contributor

visch commented Mar 22, 2022

Allow custom reports via a configuration option. Similar to https://gitlab.com/autoidm/autoidm-tap-bamboohr/-/blob/master/meltano.yml#L20

@visch visch added the enhancement New feature or request label Apr 12, 2022
guilherme-maioli pushed a commit to dadosfera/tap-googleads that referenced this issue Dec 11, 2024
* add conversion window test

* add conversion window test

* wip updated tests to worka with currently syncing dev branch [skip ci]

* Revert removal of metric compatibility removal (AutoIDM#29)

* Revert removal of metric compatibility removal

* Whitespace cleanup

* Add currently syncing (AutoIDM#24)

* Sync all customers for a given stream

* Add logging to see when we retry requests

* Update currently_syncing with customerId too. Write state as soon as we
update it

* Add the customerId to the bookmark keys

* Add shuffle for customerId and tap_stream_id; add shuffle unit tests

* Bug fix for when currently_syncing is null

* Fix exception handling typeError

* Fix none cases for currently_syncing

* Fix currently_syncing to write a tuple we can read in later

* Add get_customer_ids so we can use it in the tests

* Fix manipulated_state to account for customer_ids

* Update assertion for currently_syncing

* Fix currently syncing assertion

* Move bookmark access into Full Table assertions section

Full Table doesn't need the "stream_name and customer id" key logic

* Remove duplicate assertion

* Revert 6db016e7ec29c2b00973b671c1efdf9451aca9c2

* Update bookmark to read stream->customer->replication_key

* Update tap to write bookmarks as stream->customer->replication_key

* Update manipulated state to nest stream->customer->replication_key

* Run bookmark assertions for every customer

* Fix dict comprehension typo

* Fix conflict with main

* Remove `get_state_key` again, use env var instead of hardcoded value

* Add missing dependency

* Move currently-syncing-null-out to the end of sync to prevent gaps

* Sort selected_streams and customers to guarantee consistency across runs

* Don't let the tap write (None, None)

* Sort selected_streams and customers effectively

* Update currently_syncing test assertions

* Add sort functions for streams and customers

* Update `shuffle` to handle a missing value

* Update unit tests to use sort_function, add a test for shuffling streams

* Add end date (AutoIDM#28)

* Add optional end date, add unit tests

Co-authored-by: Andy Lu <[email protected]>

* Test functions can't be named run_test apparently

* Rename do_thing

* Extract `get_queries_from_sync` as a function

* Remove unused variable

* Refactor tests to be more explicit

* Mock singer.utils.now to return a specific date

Co-authored-by: Andy Lu <[email protected]>

* add conversion_window test

* fixed conversion window unittests, bug removed

Co-authored-by: dylan-stitch <[email protected]>
Co-authored-by: Andy Lu <[email protected]>
Co-authored-by: kspeer <[email protected]>

* Bump to v0.2.0, update changelog (AutoIDM#31)

* Bump to v0.2.0, update changelog

* Add link for this PR, fix link syntax

* Update changelog format

* expanded conversion window testing for error case, BUG linked

* parallelism 8 -> 12

* added unittest for start date within conversion window

Co-authored-by: kspeer <[email protected]>
Co-authored-by: Dylan <[email protected]>
Co-authored-by: dylan-stitch <[email protected]>
Co-authored-by: Andy Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant