Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start_date should be less than end_date #37

Open
visch opened this issue Mar 31, 2022 · 0 comments
Open

start_date should be less than end_date #37

visch opened this issue Mar 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@visch
Copy link
Contributor

visch commented Mar 31, 2022 •
edited
Loading

If this isn't true you won't get results you would expect (Not all data). We should force this by throwing an exception if that's not the case!
@visch visch added the enhancement New feature or request label Apr 12, 2022
guilherme-maioli pushed a commit to dadosfera/tap-googleads that referenced this issue Dec 11, 2024
@luandy64 @bryantgray @dsprayberry
Pre beta bugfixes (AutoIDM#39)
1ec469b 
* break out field exlusion tests for parallelism

* remove click_performance_report

* update selection for click_performance_report, failing mutual exlusion case commented out

* [skip ci] WIP on invalid exclusion test

* fix sync canary

* Fix field exclusion

* Remove unused field `selectable`

* Give `_sdc_record_hash` a behavior for consistency

* Fix integration test

* refactor field gatherer, uncomment assertions, test failing

* exlusion tests passing locally

* adding mutual exlusion check to discovery

* Transform `type_` to `type` (AutoIDM#36)

Co-authored-by: Bryant Gray <[email protected]>

* Report streams prefix resource names (AutoIDM#37)

* Prepend resource name in the schema

* Prepend resource name in the metadata

* Prepend resource name in the transform_keys

* Prepend resource name in expected_default_fields

Co-authored-by: Bryant Gray <[email protected]>

* Change `_sdc_record_hash` to sorted list of tuples (AutoIDM#38)

Co-authored-by: Bryant Gray <[email protected]>

* Fix tests

* Fix more tests

Co-authored-by: kspeer <[email protected]>
Co-authored-by: Bryant Gray <[email protected]>
Co-authored-by: dsprayberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@visch