-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify components to componentize #15
Comments
A big +1 for components. If we're doing this it would be good to think about maximising the structure and getting it right to align with the Sass. I'd really like to be part of that. |
Additions:
|
I'm very excited about this. As far as I understand React, we will need some sort of container component for instances of multiple Further, I don't believe either WP-API or the WordPress.com REST API currently allow you to retrieve widgets. My thought on this at the moment is a tad hackish, but would involve output buffering the sidebar into a custom endpoint created by Picard. So we wouldn't have direct interaction with Of course, this is just a "right now" solution to the issue. |
I've got a component structure going in the SPA I'm working on; give me today to get it updated on GH so you can see how I've component-ized (good word @MichaelArestad !) the _s markup.
I think the right approach is for us to write the proper endpoints for |
I disagree. We're not using the |
But this is happening. So ultimately we can use this anyway. |
No tears will be shed by me if we don't have widgets. |
Maybe widgets is something to achieve later? I don't want to get out the punt-o-matic machine, but to me I think having it work without widgets is an amazing version one with option to later bake in. |
Yep. Minimum viable epic theme is a good start. |
"Minimum viable epic theme" Sub-title waiting to happen there. |
Just noting how I've broken up components based on Underscores in my Calypso-y, theme-y thing: https://github.com/Automattic/calypso-theme |
Cool, of course widgets are already on the WP-API radar. And yes, I agree, I didn't see widgets necessarily for a Picard MVP. Just sticking a pin in it, and suggesting that adding something to |
Let's figure out some components! CC @kwight
Initial ideas that come to mind that follow the standardish class structure pretty nicely:
The text was updated successfully, but these errors were encountered: