Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update block classes for the site editor #1920

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: update block classes for the site editor #1920

merged 1 commit into from
Oct 22, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR switches some CSS classes from wpnbha to the full wp-block-newspack-blocks-homepage-articles; the lack of the wp-block prefix was causing some styles to get stripped from the Site Editor.

This only seems to affect the styles loaded here and not the regular SCSS.

Closes #1826 and see 1200550061930446-as-1208594353528752

How to test the changes in this Pull Request:

  1. Start with a block theme like Twenty Twenty Four (don't use the Newspack Block theme because it has some CSS in it that hides this issue).
  2. Add a homepage posts block to the footer template part, and set it to 'Grid' layout.
  3. Note the oversized images you get in the Site Editor; if you have a post with more than one you'll also get a weird overlap:

CleanShot 2024-10-22 at 12 41 27

  1. Apply this PR.
  2. Confirm the images look as expected in the Site Editor:

CleanShot 2024-10-22 at 12 40 05

  1. Confirm a block with the same settings in the regular page editor or on the front end looks okay.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner October 22, 2024 19:45
leogermani
leogermani approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the issue and the fix!

@leogermani leogermani mentioned this pull request Oct 22, 2024
Open
@laurelfulford
Copy link
Contributor Author

Thanks @leogermani!

@laurelfulford laurelfulford merged commit 26136e1 into trunk Oct 22, 2024
9 checks passed
@laurelfulford laurelfulford deleted the fix/site-editor-assets branch October 22, 2024 21:02
leogermani pushed a commit that referenced this pull request Oct 25, 2024
@laurelfulford @leogermani
fix: update block classes for the site editor (#1920)
1a07ad0
matticbot pushed a commit that referenced this pull request Oct 25, 2024
@semantic-release-bot
chore(release): 4.2.4-alpha.2 [skip ci]
688771b 
## [4.2.4-alpha.2](v4.2.4-alpha.1...v4.2.4-alpha.2) (2024-10-25)

### Bug Fixes

* update block classes for the site editor ([#1920](#1920)) ([1a07ad0](1a07ad0))
matticbot pushed a commit that referenced this pull request Oct 28, 2024
@semantic-release-bot
chore(release): 4.3.1 [skip ci]
cbcb6de 
## [4.3.1](v4.3.0...v4.3.1) (2024-10-28)

### Bug Fixes

* articles block fail to get all inner blocks ([#1878](#1878)) ([c699724](c699724))
* deprecate video playlist block ([#1903](#1903)) ([4876de6](4876de6))
* potential fatal with invalid attribute combo ([#1900](#1900)) ([adf2e9d](adf2e9d))
* update block classes for the site editor ([#1920](#1920)) ([1a07ad0](1a07ad0))
matticbot pushed a commit that referenced this pull request Nov 6, 2024
@semantic-release-bot
chore(release): 4.3.5-alpha.1 [skip ci]
12f27ba 
## [4.3.5-alpha.1](v4.3.4...v4.3.5-alpha.1) (2024-11-06)

### Bug Fixes

* add check if product can be purchased ([#1916](#1916)) ([cbe0cdb](cbe0cdb))
* **modal-checkout:** disable Continue button until JS is loaded ([d616ca3](d616ca3))
* revert check for is product purchaseable ([#1924](#1924)) ([bcbe089](bcbe089))
* update block classes for the site editor ([#1920](#1920)) ([26136e1](26136e1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.3.5-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 11, 2024
@semantic-release-bot
chore(release): 4.3.5 [skip ci]
fb7ec7c 
## [4.3.5](v4.3.4...v4.3.5) (2024-11-11)

### Bug Fixes

* add check if product can be purchased ([#1916](#1916)) ([cbe0cdb](cbe0cdb))
* **modal-checkout:** disable Continue button until JS is loaded ([d616ca3](d616ca3))
* revert check for is product purchaseable ([#1924](#1924)) ([bcbe089](bcbe089))
* update block classes for the site editor ([#1920](#1920)) ([26136e1](26136e1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog Posts Block - Featured Images Oversized and Overlap in the Editor
3 participants
@laurelfulford @matticbot @leogermani