Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Post Type filter optional #138

Open
marcusquinn opened this issue Oct 30, 2017 · 2 comments
Open

Make the Post Type filter optional #138

marcusquinn opened this issue Oct 30, 2017 · 2 comments

Comments

@marcusquinn
Copy link

We've disabled the following to enable usage for Custom Post Types:

public function display_post_types_selection() {
    // @TODO add more suitable filters
    $post_types = get_post_types( array( 'public' => true ) );

Any chance you can make this an option please? Perhaps with a disclaimer that not all CPTs may work if they use custom tables if you're concerned about that.

@philipjohn
Copy link
Contributor

Hi!

We've disabled the following to enable usage for Custom Post Types:

How have you disabled exactly? Also, I'm curious what was happening before? Were CPTs not showing for you? This code should result in any public post types being visible, including CPTs.

not all CPTs may work if they use custom tables

Could you elaborate on this bit please? Is something not working for you in Syndication that means you've had to disable this?

Thanks

@marcusquinn
Copy link
Author

Aloha!

Sure - before the patch a bunch of Post Types we'd like to syndicate were missing from here:

/wp-admin/edit.php?post_type=syn_site&page=push-syndicate-settings

this is them now showing :) :

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants