Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce Filter by Price block fields padding issue in Assembler theme #8033

Open
marissaexplores opened this issue Aug 23, 2024 · 3 comments · May be fixed by #8550
Open

WooCommerce Filter by Price block fields padding issue in Assembler theme #8033

marissaexplores opened this issue Aug 23, 2024 · 3 comments · May be fixed by #8550
Assignees
Labels

Comments

@marissaexplores
Copy link

marissaexplores commented Aug 23, 2024

Quick summary

The Filter by Price block fields do not show the whole min/max price.

Annotation on 2024-08-23 at 12-08-16

This issue is occurring because of the padding on the field.

I've tested the field in other themes like Twenty Twenty-Four, Tazza, and Tsubaki. This issue does not occur in those themes because they have set the input field padding to padding: 8px;, while Assembler has it set at padding:0.8rem 1rem;.

Steps to reproduce

  1. Install Assembler theme
  2. Go to Appearance > Editor > Templates > Product Catalog
  3. Add the Filter by Price block to the page
  4. View the min/max fields are cutting-off the prices

A clear and concise description of what you expected to happen.

The user expects to see the whole number in the min/max fields of the Filter by Price block.

What actually happened

The padding prevents users from seeing the whole price in the fields.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Add this CSS as a workaround:

.wc-block-price-slider input:not([type="submit"]):not([type="checkbox"]) {
padding: 8px;
}

Platform (Simple and/or Atomic)

Atomic

Logs or notes

I am currently only seeing this issue in the Assembler theme.

@retnonindya
Copy link

📌 REPRODUCTION RESULTS
Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Screenshot 2024-09-11 at 4 16 54 PM

I also noticed the slider (?) overlaps with the price box.

Screenshot 2024-09-11 at 4 18 14 PM

📌 ACTIONS

  • Triaged

@agrullon95
Copy link

Hey @MaggieCabrera, I am checking if this is still on your radar. Thanks!

@MaggieCabrera
Copy link
Contributor

the PR is done and waiting for review @agrullon95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants