Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests to catch errors that happen when non-admin users log to wp-admin #5101

Open
leonardola opened this issue Nov 10, 2022 · 6 comments · May be fixed by #10374
Open

Add E2E tests to catch errors that happen when non-admin users log to wp-admin #5101

leonardola opened this issue Nov 10, 2022 · 6 comments · May be fixed by #10374
Assignees
Labels
category: e2e Issues and PRs related to e2e tests. focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). needs prioritisation Triage finished and issues are ready for the following processing. status: has pr The issue has a PR. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@leonardola
Copy link
Contributor

We need to add E2E tests to prevent errors like #5096 from happening again.

Test case:

  • Create non-admin user (Eg: editor)
  • Log to wp-admin
  • Make sure no errors show up
@leonardola leonardola added the category: e2e Issues and PRs related to e2e tests. label Nov 10, 2022
@jbordonado
Copy link
Contributor

For now, a test was added to the critical flow: https://github.com/Automattic/woocommerce-payments/wiki/Testing-instructions-for-critical-flows#open-admin-area-as-non-admin

Ideally, an E2E test will cover that scenario.

@jbordonado jbordonado added type: task The issue is an internally driven task (e.g. from another A8c team). needs prioritisation Triage finished and issues are ready for the following processing. labels Nov 16, 2022
@ismaeldcom ismaeldcom self-assigned this Nov 28, 2022
@ismaeldcom ismaeldcom removed their assignment Dec 9, 2022
@zmaglica
Copy link
Contributor

This issue impacts E2E, so assigning to Harmony (based on team responsibilities Pc2DNy-3z-p2) @deepakpathania . Please don't hesitate to ping another team lead if you think that the other team might be a better solution.
Assigning as part of Gamma Triage process PcreKM-yM-p2.

@deepakpathania
Copy link
Contributor

Harmony won't be working on adding new E2E tests for product flows, this could potentially go to Gamma or Moltres IMO but not sure.

@haszari haszari added the focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). label Mar 11, 2024
@vbelolapotkov
Copy link
Collaborator

@dwainm sending this one to your team's maintenance backlog. I've assigned the issue to you for this, please take care of adding it to the team board.

Note it has some overlaps with upcoming project, but treat this one as a maintenance issue, please.

@allie500
Copy link
Contributor

Moving to on-hold until PR #10352 is merged.

@allie500
Copy link
Contributor

Picking this one back up as #10352 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: e2e Issues and PRs related to e2e tests. focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). needs prioritisation Triage finished and issues are ready for the following processing. status: has pr The issue has a PR. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
9 participants