Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment replies via Federation: @mention in Federated reply is wrapped in a paragraph #1135

Closed
jeherve opened this issue Jan 8, 2025 · 2 comments · Fixed by #1137
Closed

Comments

@jeherve
Copy link
Member

jeherve commented Jan 8, 2025

Quick summary

This is a follow-up to #844, and its fix #1086. The added @mention works well, but for some reason a paragraph is added around the mention, breaking the mention into its own line.

Here is an example:

Steps to reproduce

  1. Publish a post
  2. Have another comment reply to the post on the Fediverse
  3. On your site, reply to the comment via Federation
  4. View the reply in the Fediverse client

What you expected to happen

I would expect the reply to include a @mention of the person I'm replying to, immediately followed by my reply.

What actually happened

Instead the @mention is followed by a line break.

Impact

All

Available workarounds?

There is no user impact

Logs or notes

No response

Copy link

github-actions bot commented Jan 8, 2025

This issue could use some more labels, to help prioritize and categorize our work. Could you please add at least a [Type], a [Feature], and a [Pri] label?

@NiceGuy2065
Copy link

I can confirm the bug, previously mentioned (with another example in the wild) in #1124.

Thanks @jeherve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants