Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing fonts in site editor causes blocks to break #73624

Open
brittanygray902 opened this issue Feb 21, 2023 · 10 comments
Open

Changing fonts in site editor causes blocks to break #73624

brittanygray902 opened this issue Feb 21, 2023 · 10 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Simple [Pri] Low Address when resources are available. [Status] Auto-allocated Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@brittanygray902
Copy link

Quick summary

User has the theme Twenty Twenty-Three

When changing font for blocks the block is broken and shows error message.

"This block contains unexpected or invalid content. Attempt Block Recovery."

Steps to reproduce

(Could not reproduce on my own test site)

Steps to reproduce:

Set theme: Twenty Twenty -three

  1. Open Site Editor
  2. Select block > Change font (Playfair Display seems to break blocks every time so I'd try this one)

What you expected to happen

When changing the fonts you expect the font to change / apply, with no errors.

What actually happened

When changing fonts on a test site I did not see the same error message come up.

However, on the user's site they continue to get the error when changing fonts - specifically they notice this when changing to the font Playfair Display.

The error message is removed and blocks display / function properly when the default font is set back.

Impact

One

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

Theme: Twenty Twenty-Three
Follow up: 5979020-ZD

@brittanygray902 brittanygray902 added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged User Report labels Feb 21, 2023
@github-actions github-actions bot added [Platform] Simple [Pri] Low Address when resources are available. labels Feb 21, 2023
@github-actions
Copy link

github-actions bot commented Feb 21, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 5979020-zen
  • 7617764-zen

@sophiegyo
Copy link

I can replicate this on my Simple test site, and I am very confident that it is specific to when a font is applied to a block that sits inside a parent block which allows nested blocks, e.g. group or column block.

I was testing it out before I found this GH report - here's my recording:

Screen.Capture.on.2023-02-23.at.14-53-46.mp4

@sophiegyo
Copy link

I just tested again and I found that this workaround can help:

  1. Ensure paragraph block does not have a custom font
  2. Set font on its parent container instead
  3. Save, refresh
  4. No error.

@kavyagokul
Copy link

📌 SCRUBBING : RESULT

  • Tested on P2 - Replicated
  • Tested on Simple - Replicated
  • Tested on AT - Could Not Replicate
  • Tested on Self-hosted - Could Not Replicate
  • Replicable on Core - No

📌 FINDINGS/SCREENSHOTS/VIDEO

  • As mentioned above, this only happens with paragraphs inside a container

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

@kavyagokul kavyagokul added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Mar 7, 2023
@eoinsav
Copy link

eoinsav commented Sep 18, 2023

I am seeing this on my personal site too. I have multiple Paragraph Blocks inside a Group Block and each of them has a Custom Font added through the default Paragraph Block Settings. They all have the Attempt Block Recovery error.

I am getting the same on the Timeline Block when I have Paragraph Blocks with a custom font inside the Timeline Entries.

I have multiple fonts in the container which is why the above workaround doesn't work.

Markup 2023-09-18 at 13 25 11

Clicking Attempt Block Recovery gets rid of the notice until the next time I open the editor. Clicking Resolve instead of Attempt Block Recovery just strips the Block of all the customizations, which isn't ideal.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 18, 2023
@eduardozulian
Copy link
Member

This is also happening on 7617764-zen

@liviopv liviopv added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Jan 30, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 30, 2024
@liviopv liviopv moved this from Triaged to Needs Triage in Automattic Prioritization: The One Board ™ Jan 30, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 30, 2024
@liviopv
Copy link

liviopv commented Jan 30, 2024

Adjusting the labels and moving to the non-deprecated board based on p58i-gz0-p2

@matiasbenedetto matiasbenedetto self-assigned this Jan 17, 2025
@matiasbenedetto
Copy link
Member

The problems reported in this issue are not reproducible anymore. The editor is working as expected, following the reproduction steps mentioned here, so I'm closing the issue. I've included below a screencast of the testing in Simple sites.

Screencast.from.2025-01-17.12-27-48.mp4

@eoinsav
Copy link

eoinsav commented Jan 17, 2025

Hi @matiasbenedetto, I think you need to refresh the editor to see the error. I am still experiencing it:

Screen.Capture.on.2025-01-17.at.10-50-15.mp4

@eoinsav eoinsav reopened this Jan 17, 2025
@matticbot matticbot moved this from Done 🎉 to Triaged in Automattic Prioritization: The One Board ™ Jan 17, 2025
@matiasbenedetto
Copy link
Member

Hi @eoinsav, I refreshed the site several times, and I wasn't able to reproduce it.

2025-01-17.16-13-11.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Simple [Pri] Low Address when resources are available. [Status] Auto-allocated Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

9 participants