You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Billing Transactions state used in add-ons will need to surface into data-stores (or be passed in as a prop) as part of pau2Xa-59h-p2
Billing transactions are used for finding purchased space upgrades. I am not sure if this needs a refactor of its own (whether something we can retrieve through the site or user purchases or keep using the transaction/billing log for it).
I think the simplest to unblock the NPM migration is to actually pass either useSpaceUpgradesPurchased as a helper or an object spaceUpgradesPurchased into the grid. The alternative (to migrate the Billing state to data stores) feels like a humongous effort - there is also I think UI state for the billing transaction filters being used in add-ons that's not readily portable.
We need to decide on the best course of action with some reflection i.e. this will need to reach the usePricingMetaForGridPlans hook, which is used at various places, not only in the plans-grid-next package. Having a self-contained hook (that queries billing transactions) is easier reusable & portable (otherwise we may need to feed these extra layers on every call for consistent values).
Related exploratory (parent) PR: #85465
Related GH issue: #81374
Checklist
Decide on the best course of action from above and implement the migration/refactor
Details
Billing Transactions state used in add-ons will need to surface into data-stores (or be passed in as a prop) as part of pau2Xa-59h-p2
Billing transactions are used for finding purchased space upgrades. I am not sure if this needs a refactor of its own (whether something we can retrieve through the site or user purchases or keep using the transaction/billing log for it).
I think the simplest to unblock the NPM migration is to actually pass either
useSpaceUpgradesPurchased
as a helper or an objectspaceUpgradesPurchased
into the grid. The alternative (to migrate the Billing state to data stores) feels like a humongous effort - there is also I think UI state for the billing transaction filters being used in add-ons that's not readily portable.We need to decide on the best course of action with some reflection i.e. this will need to reach the
usePricingMetaForGridPlans
hook, which is used at various places, not only in theplans-grid-next
package. Having a self-contained hook (that queries billing transactions) is easier reusable & portable (otherwise we may need to feed these extra layers on every call for consistent values).Related exploratory (parent) PR: #85465
Related GH issue: #81374
Checklist
/add-ons
after cancelling. #86147Related
#81374
The text was updated successfully, but these errors were encountered: