Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiTS & LoTS not showing the upgrade tooltip with default style variation #98324

Closed
rcrdortiz opened this issue Jan 14, 2025 · 7 comments · Fixed by #98429
Closed

LiTS & LoTS not showing the upgrade tooltip with default style variation #98324

rcrdortiz opened this issue Jan 14, 2025 · 7 comments · Fixed by #98429
Assignees
Labels
[Experiment] AI labels added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@rcrdortiz
Copy link
Contributor

Quick summary

On the Logged-in and Logged-out Theme Showcase, the upgrade badge does not display the tooltip indicating the required plan unless a non-default style variation is selected. This makes it difficult to determine which plan the theme requires.

Steps to reproduce

  1. Go to /themes while logged-in and out
  2. Hover over the Upgrade badge.
  3. You will not see any tooltip.
  4. Select a non-default style variation
  5. You will see the tooltip while hovering over the Upgrade badge.
non-default.mp4

What you expected to happen

I expected to see the tooltip regardless of the style variation selected.

What actually happened

By default, we don't show the tooltip

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@rcrdortiz rcrdortiz added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 14, 2025
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Appearance & Themes: The issue involves the display and appearance of the upgrade badge within the themes, indicating a theme-related concern.
  • [Feature] Plans & Upgrades: The issue directly pertains to the upgrade badge and its associated tooltip, which is related to user plans and upgrades.
  • [Feature] Theme Showcase: The problem occurs on the Theme Showcase page, as indicated in the title and issue body, specifically referencing how themes show information regarding upgrades.

@github-actions github-actions bot added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Experiment] AI labels added labels Jan 14, 2025
@matticbot matticbot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jan 14, 2025
@Robertght
Copy link

I can replicate this.

I remember leaving a note on this: #97380

And it looks like the alt was removed here, but I don't know if that impacts the hover on the label.

Flagging this for @Automattic/t-rex

@Robertght Robertght added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Jan 14, 2025
@Robertght Robertght moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 14, 2025
@jeryj jeryj self-assigned this Jan 14, 2025
@jeryj
Copy link
Contributor

jeryj commented Jan 14, 2025

Looking into this. It seems like the default style (first one) is free, but the additional ones require an upgrade. So, I think the upgrade badge itself is misleading. You don't need to upgrade to use the default styles. You need to upgrade if you use the other styles.

Dadaist theme page showing Default style section and upgrade style sections

So, would the best fix be one of these?

1. Remove the upgrade badge if you're on the default style. Show the upgrade badge once the user clicks a style variation that requires an upgrade.
2. Change the badge when on the default theme style to say, "Upgrades available" or some other word that indicates the default is free but you can purchase other styles?

I think #1 is best. It's free when you're on the default, but if you click a style that needs upgraded, we let you know.

Never mind! I was misunderstanding the individual theme page. You do have to upgrade to activate that theme.

@jeryj
Copy link
Contributor

jeryj commented Jan 14, 2025

Debugged more and here are my current thoughts. I'll keep looking more later today.

In the above case with the Dadaist theme:

  • Starting from logged out (no plan)
  • Go to /themes
  • Upgrade badge has a tooltip of "This theme is included in the Personal plan."
  • Upgrade badge for Style Variations requires the Premium plan, so it shows a different badge (that looks the same, but has a tooltip).

That looks like it's working right.

If you are logged in and on a free plan, it looks like:

  • Go to /themes
  • Upgrade badge does not have a tooltip
  • Upgrade badge for Style Variations requires the Premium plan, so it shows a different badge (that looks the same, but has a tooltip).

So, if you are logged in and your theme requires an upgrade, we should always tell you in a tooltip what you need to do to access that plan. In the logged-in-on-free plan case, it doesn't show a tooltip. We should still be showing the, "This theme is included in the Personal plan" tooltip.

@jeryj
Copy link
Contributor

jeryj commented Jan 14, 2025

Sorry for all the noise here and misdirections in my comments. I keep running into dev set-up issues as I get onboarded to the various dev environments here.

Here's my final answer for this issue: This tooltip was intentionally removed in this PR as proposed in this issue.

So, this needs a decision on which direction we're going. cc @richtabor @fditrapani @mikachan

Is the direction to also remove this tooltip for the style variations?

@fditrapani
Copy link
Contributor

No problem @jeryj. Thanks for the ping! We're in the process of replacing the upgrade badge, style variations, and tooltips with the new copy outlined here: #95471 (comment). @mikachan are you still able to complete the next steps?

@mikachan
Copy link
Member

@fditrapani Thanks for the ping! Yes, I'm working through those copy changes now and hoping to have a PR up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

6 participants