-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LiTS & LoTS not showing the upgrade tooltip with default style variation #98324
Comments
OpenAI suggested the following labels for this issue:
|
Looking into this.
Never mind! I was misunderstanding the individual theme page. You do have to upgrade to activate that theme. |
Debugged more and here are my current thoughts. I'll keep looking more later today. In the above case with the Dadaist theme:
That looks like it's working right. If you are logged in and on a free plan, it looks like:
So, if you are logged in and your theme requires an upgrade, we should always tell you in a tooltip what you need to do to access that plan. In the logged-in-on-free plan case, it doesn't show a tooltip. We should still be showing the, "This theme is included in the Personal plan" tooltip. |
Sorry for all the noise here and misdirections in my comments. I keep running into dev set-up issues as I get onboarded to the various dev environments here. Here's my final answer for this issue: This tooltip was intentionally removed in this PR as proposed in this issue. So, this needs a decision on which direction we're going. cc @richtabor @fditrapani @mikachan Is the direction to also remove this tooltip for the style variations? |
No problem @jeryj. Thanks for the ping! We're in the process of replacing the upgrade badge, style variations, and tooltips with the new copy outlined here: #95471 (comment). @mikachan are you still able to complete the next steps? |
@fditrapani Thanks for the ping! Yes, I'm working through those copy changes now and hoping to have a PR up soon. |
Quick summary
On the Logged-in and Logged-out Theme Showcase, the upgrade badge does not display the tooltip indicating the required plan unless a non-default style variation is selected. This makes it difficult to determine which plan the theme requires.
Steps to reproduce
Upgrade
badge.Upgrade
badge.non-default.mp4
What you expected to happen
I expected to see the tooltip regardless of the style variation selected.
What actually happened
By default, we don't show the tooltip
Impact
All
Available workarounds?
No but the platform is still usable
If the above answer is "Yes...", outline the workaround.
No response
Platform (Simple and/or Atomic)
Simple
Logs or notes
No response
The text was updated successfully, but these errors were encountered: