Update implicit-hie-cradle #2342

Avi-D-coder · 2021-11-10T20:06:03Z

Fix: Avi-D-coder/implicit-hie#42
@fendor does Avi-D-coder/implicit-hie-cradle@edc3420 look like it solves the problem?

Needs nix flake update before merging.

Fix: Avi-D-coder/implicit-hie#42

fendor · 2021-11-11T09:23:39Z

Idea looks good, I noticed the PR a bit too late and have some comments on: Avi-D-coder/implicit-hie-cradle@edc3420

Avi-D-coder · 2021-11-11T13:34:47Z

@fendor I addressed your review. Good catch!

Avi-D-coder · 2021-11-11T15:38:30Z

@fendor can you take a look at Testing / test (8.10.7, ubuntu-latest) (pull_request). Is cabal repl failing?

fendor · 2021-11-11T19:18:27Z

Hm, the test fail looks weird to me:

Got unexpected diagnostics for Uri {getUri = "file:///tmp/extra-dir-16848491138556/RecordDot.hs"} got List [Diagnostic {_range = Range {_start = Position {_line = 0, _character = 0}, _end = Position {_line = 1, _character = 0}}, _severity = Just DsError, _code = Nothing, _source = Just "compiler", _message = "cabal: streamingProcess: chdir: invalid argument (Bad file descriptor)", _tags = Nothing, _relatedInformation = Nothing}]

Not sure what is going on.

jneira · 2021-11-17T21:25:32Z

@Avi-D-coder thanks for contributing again here 😄 do you think would be time to mark it as ready for review?

Avi-D-coder · 2021-11-17T21:37:25Z

let's see if this round of tests pass.
Maybe it was just a fluke error.

jneira · 2021-11-17T21:47:02Z

it seems nix config need some tweaks: https://github.com/haskell/haskell-language-server/runs/4243966228?check_suite_focus=true

jneira · 2021-11-18T06:37:09Z

hmm not sure if the test fail belongs to the flaky ones:

 FAIL (0.63s)
    test/exe/Main.hs:5496:
    Got unexpected diagnostics for Uri {getUri = "file:///tmp/extra-dir-53701638320214/dirB/Foo.hs"} got List [Diagnostic {_range = Range {_start = Position {_line = 0, _character = 0}, _end = Position {_line = 1, _character = 0}}, _severity = Just DsError, _code = Nothing, _source = Just "compiler", _message = "cabal: streamingProcess: chdir: invalid argument (Bad file descriptor)", _tags = Nothing, _relatedInformation = Nothing}]
    Use -p '/use rootUri/' to rerun this test only.

does it passes locally?

Avi-D-coder · 2021-11-18T13:51:13Z

nix build works, but I get this from nix develop

❯ nix develop --print-build-logs --command cabal update
cabal2nix-hls-rename-plugin> installing
cabal2nix-hls-test-utils> installing
cabal2nix-shake-bench> installing
myst-parser> trying https://files.pythonhosted.org/packages/source/m/myst-parser/myst-parser-0.15.1.tar.gz
github> setupCompilerEnvironmentPhase
myst-parser>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
github> Build with /nix/store/m0xw42nwrlfznfasiqfzwdavi4421x32-ghc-8.10.7.
myst-parser>                                  Dload  Upload   Total   Spent    Left  Speed
source> trying https://github.com/readthedocs/sphinx_rtd_theme/archive/34f81daaf52466366c80003db293d50075c1b896.tar.gz
source>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
source>                                  Dload  Upload   Total   Spent    Left  Speed
source> 100   170  100   170    0     0    495      0 --:--:-- --:--:-- --:--:--   495
myst-parser>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
github> unpacking sources
github> unpacking source archive /nix/store/imx36w92rwaxnlb5299nw98bfgz9wlbh-github-0.27.tar.gz
github> source root is github-0.27
github> setting SOURCE_DATE_EPOCH to timestamp 1000000000 of file github-0.27/src/GitHub/Request.hs
github> patching sources
github> applying patch /nix/store/pgl2rm264f5s2pg1cxid5immb3yp0f5i-514b175851dd7c4a9722ff203dd6f652a15d33e8.patch
github> patching file github.cabal
github> Hunk #1 FAILED at 178.
github> 1 out of 1 hunk FAILED -- saving rejects to file github.cabal.rej
github> patching file src/GitHub/Request.hs
github> Reversed (or previously applied) patch detected!  Assume -R? [n]
github> Apply anyway? [n]
github> Skipping patch.
github> 2 out of 2 hunks ignored -- saving rejects to file src/GitHub/Request.hs.rej
error: builder for '/nix/store/4k1i98049sk7zii17vrsgrzprny5yds0-github-0.27.drv' failed with exit code 1;
       last 10 log lines:
       > patching sources
       > applying patch /nix/store/pgl2rm264f5s2pg1cxid5immb3yp0f5i-514b175851dd7c4a9722ff203dd6f652a15d33e8.patch
       > patching file github.cabal
       > Hunk #1 FAILED at 178.
       > 1 out of 1 hunk FAILED -- saving rejects to file github.cabal.rej
       > patching file src/GitHub/Request.hs
       > Reversed (or previously applied) patch detected!  Assume -R? [n]
       > Apply anyway? [n]
       > Skipping patch.
       > 2 out of 2 hunks ignored -- saving rejects to file src/GitHub/Request.hs.rej
       For full logs, run 'nix log /nix/store/4k1i98049sk7zii17vrsgrzprny5yds0-github-0.27.drv'.
error: 1 dependencies of derivation '/nix/store/27wv7z2z30l68aqgmzasfwmr1h28mn8p-ghc-8.10.7-with-packages.drv' failed to build
error: 1 dependencies of derivation '/nix/store/l8kibyqm7p6wsdp8gfwraka9zqppqf81-gen-hls-changelogs.drv' failed to build
error: 1 dependencies of derivation '/nix/store/z3n7lkwwvggvf933cbhnmwvxgrhs27pa-ghc-shell-for-packages-0-env.drv' failed to build

Avi-D-coder · 2021-11-18T15:17:12Z

Nix is good now, but that one test keeps failing. I have no idea why.
https://github.com/haskell/haskell-language-server/runs/4252161650?check_suite_focus=true

Avi-D-coder · 2021-11-23T17:11:20Z

@fendor how would you feel about changing it to don't generate a cradle based on .cabal file if cabal version >= 3.4 && ghc >= 9?
I'm not really clear what is wrong with 8.10.7, but we can at least use cabal repl for ghc 9.

fendor · 2021-11-23T21:58:27Z

As far as I can tell, no tests of GHC >= 9 have been run yet, only the build jobs. This is probably a somewhat real regression that we ought to look into. I'll try to take a look in the next days.

fendor · 2021-11-24T16:27:17Z

The test that fails is interesting. It basically implicitly tests the implicit session setup.
Do we also have explicit tests that test the implicit session setup?

Avi-D-coder · 2021-11-24T16:45:11Z

The test that fails is interesting. It basically implicitly tests the implicit session setup. Do we also have explicitly tests that test the implicit session setup?

I'm not aware of any.

jneira · 2021-11-29T13:37:57Z

Thanks for the work doing here
The consecutive hackage releases of implicit-hie has leaked out in nix builds (and maybe in some hackage ones)
I would consider to make changes in implicit-hie using pr's with some code review and testing hls against the desired version (maybe in this repo) using source-repository-package.

Avi-D-coder · 2021-11-29T15:03:37Z

#2398 (comment)
Work on this PR will continue on implicit-hie-cradle-0.4.*, when this PR is finished I will publish 0.4 as 0.6.

Update implicit-hie-cradle

0fbfeff

Fix: Avi-D-coder/implicit-hie#42

Avi-D-coder requested a review from fendor November 10, 2021 20:06

Update cabal index

a45d021

Avi-D-coder added 2 commits November 11, 2021 08:53

Update ghc 9* cabal index

2a1aad4

Merge branch 'master' into update-implicit-hie-cradle-4

c865a3f

jneira added 2 commits November 16, 2021 08:42

Merge branch 'master' into update-implicit-hie-cradle-4

e9220de

Merge branch 'master' into update-implicit-hie-cradle-4

2cbff5a

Avi-D-coder marked this pull request as ready for review November 17, 2021 21:35

Avi-D-coder and others added 2 commits November 18, 2021 00:04

Update nix

b990dda

Merge branch 'master' into update-implicit-hie-cradle-4

24969f1

Revert flake update

e106250

Merge branch 'master' into update-implicit-hie-cradle-4

a0e4cd6

Avi-D-coder added 2 commits November 24, 2021 11:43

Update implicit hie cradle

f0795e9

Merge branch 'master' into update-implicit-hie-cradle-4

14a0fe7

Merge branch 'master' into update-implicit-hie-cradle-4

2062a3d

fendor mentioned this pull request Nov 25, 2021

HLS 1.5 requires hie.yaml else it would fail to run, but works in HLS 1.2 #2398

Closed

Merge branch 'master' into update-implicit-hie-cradle-4

b58cb30

Merge branch 'master' into update-implicit-hie-cradle-4

fce0719

fendor mentioned this pull request Dec 2, 2021

Extension stops working when using a common stanza in .cabal file #2432

Open

jneira linked an issue Dec 2, 2021 that may be closed by this pull request

Extension stops working when using a common stanza in .cabal file #2432

Open

Merge branch 'master' into update-implicit-hie-cradle-4

27d4907

Anton-Latukha mentioned this pull request Dec 9, 2021

Fix the nix build #2452

Merged

Anton-Latukha marked this pull request as draft December 13, 2021 15:14

fendor mentioned this pull request Mar 13, 2022

Import errors with flat files structure and multiple cabal modules #2777

Closed

fendor mentioned this pull request Mar 25, 2022

Cabal cradle doesn't recognize foreign-library sections haskell/hie-bios#341

Closed

fendor mentioned this pull request Aug 8, 2022

Fails to load with local tarballs in cabal.project #3074

Closed

pepeiborra added the status: unfinished Status for PRs that have been semi-abandoned label Aug 13, 2022

Avi-D-coder closed this Nov 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update implicit-hie-cradle #2342

Update implicit-hie-cradle #2342

Avi-D-coder commented Nov 10, 2021 •

edited by gitpod-io bot

Loading

fendor commented Nov 11, 2021

Avi-D-coder commented Nov 11, 2021

Avi-D-coder commented Nov 11, 2021

fendor commented Nov 11, 2021 •

edited

Loading

jneira commented Nov 17, 2021

Avi-D-coder commented Nov 17, 2021

jneira commented Nov 17, 2021

jneira commented Nov 18, 2021 •

edited

Loading

Avi-D-coder commented Nov 18, 2021

Avi-D-coder commented Nov 18, 2021

Avi-D-coder commented Nov 23, 2021 •

edited

Loading

fendor commented Nov 23, 2021

fendor commented Nov 24, 2021 •

edited

Loading

Avi-D-coder commented Nov 24, 2021 •

edited by fendor

Loading

jneira commented Nov 29, 2021

Avi-D-coder commented Nov 29, 2021

Update implicit-hie-cradle #2342

Update implicit-hie-cradle #2342

Conversation

Avi-D-coder commented Nov 10, 2021 • edited by gitpod-io bot Loading

fendor commented Nov 11, 2021

Avi-D-coder commented Nov 11, 2021

Avi-D-coder commented Nov 11, 2021

fendor commented Nov 11, 2021 • edited Loading

jneira commented Nov 17, 2021

Avi-D-coder commented Nov 17, 2021

jneira commented Nov 17, 2021

jneira commented Nov 18, 2021 • edited Loading

Avi-D-coder commented Nov 18, 2021

Avi-D-coder commented Nov 18, 2021

Avi-D-coder commented Nov 23, 2021 • edited Loading

fendor commented Nov 23, 2021

fendor commented Nov 24, 2021 • edited Loading

Avi-D-coder commented Nov 24, 2021 • edited by fendor Loading

jneira commented Nov 29, 2021

Avi-D-coder commented Nov 29, 2021

Avi-D-coder commented Nov 10, 2021 •

edited by gitpod-io bot

Loading

fendor commented Nov 11, 2021 •

edited

Loading

jneira commented Nov 18, 2021 •

edited

Loading

Avi-D-coder commented Nov 23, 2021 •

edited

Loading

fendor commented Nov 24, 2021 •

edited

Loading

Avi-D-coder commented Nov 24, 2021 •

edited by fendor

Loading