Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word boundary detection for smiley codes #44

Open
Azareal opened this issue Sep 19, 2018 · 2 comments
Open

Word boundary detection for smiley codes #44

Azareal opened this issue Sep 19, 2018 · 2 comments

Comments

@Azareal
Copy link
Owner

Azareal commented Sep 19, 2018

We should use a more sophisticated smiley replacement mechanism where it only replaces traditional smiley codes with their associated emoji when the smiley is a standalone word rather than embedded inside something that might very well be a piece of code or something important.

@Azareal Azareal added this to the v0.2 milestone Sep 19, 2018
@Azareal Azareal self-assigned this Sep 19, 2018
@Azareal
Copy link
Owner Author

Azareal commented Sep 19, 2018

335fe4f#diff-e3dfe1200b7b31ab4817f18df3744d9bR405 If anyone wants to take it up, it might be a while before I get around to it. Preferably without regexes.

@SUP3RIA
Copy link

SUP3RIA commented Sep 21, 2018

Quick fix: " :p " instead of ":p"

I can do it this weekend. My approach would be to use https://github.com/jdkato/prose#tokenizing for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants